diff options
| author | Ryan Moeller <[email protected]> | 2020-10-09 12:27:14 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-10-09 09:27:14 -0700 |
| commit | b7ab7ae2410f5152318cbb71675e9ba94d7562cb (patch) | |
| tree | 14ea84c66d576ff8b538509c41380cdac3fd3c4f /module | |
| parent | d0249a4bd0da59f20edadba409d0620d387e4e26 (diff) | |
Linux: Initialize zp in zfs_setattr_dir
The value of zp is used without having been initialized under some
conditions. Initialize the pointer to NULL.
Add a regression test case using chown in acl/posix. However, this is
not enough because the setup sets xattr=sa, which means zfs_setattr_dir
will not be called. Create a second group of acl tests in acl/posix-sa
duplicating the acl/posix tests with symlinks, and remove xattr=sa from
the original acl/posix tests. This provides more coverage for the
default xattr=on code.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #10043
Closes #11025
Diffstat (limited to 'module')
| -rw-r--r-- | module/os/linux/zfs/zfs_vnops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/module/os/linux/zfs/zfs_vnops.c b/module/os/linux/zfs/zfs_vnops.c index 0932b9b33..b668c7dff 100644 --- a/module/os/linux/zfs/zfs_vnops.c +++ b/module/os/linux/zfs/zfs_vnops.c @@ -2543,7 +2543,7 @@ zfs_setattr_dir(znode_t *dzp) zap_cursor_t zc; zap_attribute_t zap; zfs_dirlock_t *dl; - znode_t *zp; + znode_t *zp = NULL; dmu_tx_t *tx = NULL; uint64_t uid, gid; sa_bulk_attr_t bulk[4]; |