diff options
| author | Richard Yao <[email protected]> | 2022-11-03 12:58:14 -0400 |
|---|---|---|
| committer | Tony Hutter <[email protected]> | 2022-12-01 12:39:43 -0800 |
| commit | 256b74d0b034ff61709fca64d58f81746186eaef (patch) | |
| tree | f007e8b1a23d999d0b18883c7cd8674286150b0a /module | |
| parent | ac01b876c91ea6dbbb75775db5603077f3490f0b (diff) | |
Address warnings about possible division by zero from clangsa
* The complaint in ztest_replay_write() is only possible if something
went horribly wrong. An assertion will silence this and if it goes
off, we will know that something is wrong.
* The complaint in spa_estimate_metaslabs_to_flush() is not impossible,
but seems very unlikely. We resolve this by passing the value from
the `MIN()` that does not go to infinity when the variable is zero.
There was a third report from Clang's scan-build, but that was a
definite false positive and disappeared when checked again through
Clang's static analyzer with Z3 refution via CodeChecker.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #14124
Diffstat (limited to 'module')
| -rw-r--r-- | module/zfs/spa_log_spacemap.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/module/zfs/spa_log_spacemap.c b/module/zfs/spa_log_spacemap.c index 0dfe5b839..6a27f5759 100644 --- a/module/zfs/spa_log_spacemap.c +++ b/module/zfs/spa_log_spacemap.c @@ -690,7 +690,8 @@ spa_estimate_metaslabs_to_flush(spa_t *spa) * based on the incoming rate until we exceed it. */ if (available_blocks >= 0 && available_txgs >= 0) { - uint64_t skip_txgs = MIN(available_txgs + 1, + uint64_t skip_txgs = (incoming == 0) ? + available_txgs + 1 : MIN(available_txgs + 1, (available_blocks / incoming) + 1); available_blocks -= (skip_txgs * incoming); available_txgs -= skip_txgs; |