diff options
| author | Brian Behlendorf <[email protected]> | 2009-02-18 09:48:07 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2009-02-18 09:48:07 -0800 |
| commit | 1315c884379965af367d1a38c695f73ad7d6e0c1 (patch) | |
| tree | f4a8f81442ea2e2a0b2a922ebdaf98110d361e19 /module | |
| parent | bb01879ebe5ba5d8e2c2177d3b1ce0272c17ce07 (diff) | |
Coverity 9649, 9650, 9651: Uninit
This check was originally added to detect double initializations
of mutex types (which it did find). Unfortunately, Coverity is
right that there is a very small chance we could trigger the
assertion by accident because an uninitialized stack variable
happens to contain the mutex magic. This is particularly unlikely
since we do poison the mutexs when destroyed but still possible.
Therefore I'm simply removing the assertion.
Diffstat (limited to 'module')
| -rw-r--r-- | module/spl/spl-mutex.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/module/spl/spl-mutex.c b/module/spl/spl-mutex.c index e7ec41cf4..f0389f5d1 100644 --- a/module/spl/spl-mutex.c +++ b/module/spl/spl-mutex.c @@ -67,7 +67,6 @@ __spl_mutex_init(kmutex_t *mp, char *name, int type, void *ibc) ASSERT(mp); ASSERT(name); ASSERT(ibc == NULL); - ASSERT(mp->km_magic != KM_MAGIC); /* Never double init */ mp->km_name = NULL; mp->km_name_size = strlen(name) + 1; |