diff options
| author | luozhengzheng <[email protected]> | 2016-09-22 09:09:00 +0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2016-09-21 18:09:00 -0700 |
| commit | 160987b5762946a2d03fb608149fdc2224ec55d1 (patch) | |
| tree | 8af262b48ce7510cd20d09b89c0616b3efb2fed0 /module | |
| parent | 84347be0986fc0ba99ebb577357328c1e3f50a68 (diff) | |
Fix coverity defects
coverity scan CID:147633,type: sizeof not portable
coverity scan CID:147637,type: sizeof not portable
coverity scan CID:147638,type: sizeof not portable
coverity scan CID:147640,type: sizeof not portable
In these particular cases sizeof (XX **) happens to be equal to sizeof (X *),
but this is not a portable assumption.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: luozhengzheng <[email protected]>
Closes #5144
Diffstat (limited to 'module')
| -rw-r--r-- | module/zfs/spa.c | 2 | ||||
| -rw-r--r-- | module/zfs/zfs_fuid.c | 2 | ||||
| -rw-r--r-- | module/zfs/zfs_replay.c | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/module/zfs/spa.c b/module/zfs/spa.c index c7cfe6ee8..3264bfb10 100644 --- a/module/zfs/spa.c +++ b/module/zfs/spa.c @@ -1724,7 +1724,7 @@ spa_config_valid(spa_t *spa, nvlist_t *config) nvlist_t **child, *nv; uint64_t idx = 0; - child = kmem_alloc(rvd->vdev_children * sizeof (nvlist_t **), + child = kmem_alloc(rvd->vdev_children * sizeof (nvlist_t *), KM_SLEEP); VERIFY(nvlist_alloc(&nv, NV_UNIQUE_NAME, KM_SLEEP) == 0); diff --git a/module/zfs/zfs_fuid.c b/module/zfs/zfs_fuid.c index 93b7a8b84..3ab1c7ba0 100644 --- a/module/zfs/zfs_fuid.c +++ b/module/zfs/zfs_fuid.c @@ -691,7 +691,7 @@ zfs_fuid_info_free(zfs_fuid_info_t *fuidp) if (fuidp->z_domain_table != NULL) kmem_free(fuidp->z_domain_table, - (sizeof (char **)) * fuidp->z_domain_cnt); + (sizeof (char *)) * fuidp->z_domain_cnt); while ((zdomain = list_head(&fuidp->z_domains)) != NULL) { list_remove(&fuidp->z_domains, zdomain); diff --git a/module/zfs/zfs_replay.c b/module/zfs/zfs_replay.c index b631ba65b..eee13c065 100644 --- a/module/zfs/zfs_replay.c +++ b/module/zfs/zfs_replay.c @@ -204,7 +204,7 @@ zfs_replay_fuid_domain(void *buf, void **end, uint64_t uid, uint64_t gid) return (fuid_infop); fuid_infop->z_domain_table = - kmem_zalloc(domcnt * sizeof (char **), KM_SLEEP); + kmem_zalloc(domcnt * sizeof (char *), KM_SLEEP); zfs_replay_fuid_ugid(fuid_infop, uid, gid); @@ -228,7 +228,7 @@ zfs_replay_fuids(void *start, void **end, int idcnt, int domcnt, uint64_t uid, fuid_infop->z_domain_cnt = domcnt; fuid_infop->z_domain_table = - kmem_zalloc(domcnt * sizeof (char **), KM_SLEEP); + kmem_zalloc(domcnt * sizeof (char *), KM_SLEEP); for (i = 0; i != idcnt; i++) { zfs_fuid_t *zfuid; |