diff options
| author | Alexander Motin <[email protected]> | 2023-04-26 12:20:43 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-04-26 09:20:43 -0700 |
| commit | bba7cbf0a481ab16f9a9a4874b7dbd5682e4d3a4 (patch) | |
| tree | 9d8e0d4b65645e49aa005526945797aa33a6040c /module | |
| parent | e37a89d5d0ba07da09998de6701a6c0ec43903b7 (diff) | |
Fix positive ABD size assertion in abd_verify().
Gang ABDs without childred are legal, and they do have zero size.
For other ABD types zero size doesn't have much sense and likely
not working correctly now.
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes #14795
Diffstat (limited to 'module')
| -rw-r--r-- | module/zfs/abd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/module/zfs/abd.c b/module/zfs/abd.c index d4921d0ba..26222d2ef 100644 --- a/module/zfs/abd.c +++ b/module/zfs/abd.c @@ -109,7 +109,6 @@ void abd_verify(abd_t *abd) { #ifdef ZFS_DEBUG - ASSERT3U(abd->abd_size, >, 0); ASSERT3U(abd->abd_size, <=, SPA_MAXBLOCKSIZE); ASSERT3U(abd->abd_flags, ==, abd->abd_flags & (ABD_FLAG_LINEAR | ABD_FLAG_OWNER | ABD_FLAG_META | ABD_FLAG_MULTI_ZONE | @@ -118,6 +117,7 @@ abd_verify(abd_t *abd) IMPLY(abd->abd_parent != NULL, !(abd->abd_flags & ABD_FLAG_OWNER)); IMPLY(abd->abd_flags & ABD_FLAG_META, abd->abd_flags & ABD_FLAG_OWNER); if (abd_is_linear(abd)) { + ASSERT3U(abd->abd_size, >, 0); ASSERT3P(ABD_LINEAR_BUF(abd), !=, NULL); } else if (abd_is_gang(abd)) { uint_t child_sizes = 0; @@ -130,6 +130,7 @@ abd_verify(abd_t *abd) } ASSERT3U(abd->abd_size, ==, child_sizes); } else { + ASSERT3U(abd->abd_size, >, 0); abd_verify_scatter(abd); } #endif |