diff options
| author | Brian Behlendorf <[email protected]> | 2013-11-22 16:00:39 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2014-03-31 16:11:08 -0700 |
| commit | 9b101a73203faecdc6d466fe446d787bc341ee14 (patch) | |
| tree | 3f66497e6384d35b89dbd89ed06b229a15e13967 /module | |
| parent | 75e3ff58feda2d836c4546c5dc2e98fcd2d1a67b (diff) | |
Clarify zpool_events_next() comment
Due to the very poorly chosen argument name 'cleanup_fd' it was
completely unclear that this file descriptor is used to track the
current cursor location. When the file descriptor is created by
opening ZFS_DEV a private cursor is created in the kernel for the
returned file descriptor. Subsequent calls to zpool_events_next()
and zpool_events_seek() then require the file descriptor as an
argument to reposition the cursor. When the file descriptor is
closed the kernel state tracking the cursor is destroyed.
This patch contains no functional change, it just changes a
few variable names and clarifies the documentation.
Signed-off-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chris Dunlap <[email protected]>
Issue #2
Diffstat (limited to 'module')
| -rw-r--r-- | module/zfs/zfs_ioctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c index cd4779016..0dfda1abf 100644 --- a/module/zfs/zfs_ioctl.c +++ b/module/zfs/zfs_ioctl.c @@ -4860,11 +4860,11 @@ zfs_ioc_release(const char *pool, nvlist_t *holds, nvlist_t *errlist) /* * inputs: * zc_guid flags (ZEVENT_NONBLOCK) + * zc_cleanup_fd zevent file descriptor * * outputs: * zc_nvlist_dst next nvlist event * zc_cookie dropped events since last get - * zc_cleanup_fd cleanup-on-exit file descriptor */ static int zfs_ioc_events_next(zfs_cmd_t *zc) |