aboutsummaryrefslogtreecommitdiffstats
path: root/module
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2020-04-09 09:16:46 -0700
committerGitHub <[email protected]>2020-04-09 09:16:46 -0700
commit68dde63d138882860109178f4ab0b7b1b1bb3cfd (patch)
treed2400bcdb5bb4c7689fa2392023002aa0a2990e6 /module
parent01c4f2bf2933319e876e8f695e97d0719a9db0ed (diff)
Linux 5.7 compat: blk_alloc_queue()
Commit https://github.com/torvalds/linux/commit/3d745ea5 simplified the blk_alloc_queue() interface by updating it to take the request queue as an argument. Add a wrapper function which accepts the new arguments and internally uses the available interfaces. Other minor changes include increasing the Linux-Maximum to 5.6 now that 5.6 has been released. It was not bumped to 5.7 because this release has not yet been finalized and is still subject to change. Added local 'struct zvol_state_os *zso' variable to zvol_alloc. Reviewed-by: George Melikov <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #10181 Closes #10187
Diffstat (limited to 'module')
-rw-r--r--module/os/linux/zfs/zvol_os.c48
1 files changed, 24 insertions, 24 deletions
diff --git a/module/os/linux/zfs/zvol_os.c b/module/os/linux/zfs/zvol_os.c
index 9439954b8..fe45d76a6 100644
--- a/module/os/linux/zfs/zvol_os.c
+++ b/module/os/linux/zfs/zvol_os.c
@@ -754,6 +754,7 @@ static zvol_state_t *
zvol_alloc(dev_t dev, const char *name)
{
zvol_state_t *zv;
+ struct zvol_state_os *zso;
uint64_t volmode;
if (dsl_prop_get_integer(name, "volmode", &volmode, NULL) != 0)
@@ -766,39 +767,38 @@ zvol_alloc(dev_t dev, const char *name)
return (NULL);
zv = kmem_zalloc(sizeof (zvol_state_t), KM_SLEEP);
- zv->zv_zso = kmem_zalloc(sizeof (struct zvol_state_os), KM_SLEEP);
+ zso = kmem_zalloc(sizeof (struct zvol_state_os), KM_SLEEP);
+ zv->zv_zso = zso;
list_link_init(&zv->zv_next);
-
mutex_init(&zv->zv_state_lock, NULL, MUTEX_DEFAULT, NULL);
- zv->zv_zso->zvo_queue = blk_alloc_queue(GFP_ATOMIC);
- if (zv->zv_zso->zvo_queue == NULL)
+ zso->zvo_queue = blk_generic_alloc_queue(zvol_request, NUMA_NO_NODE);
+ if (zso->zvo_queue == NULL)
goto out_kmem;
- blk_queue_make_request(zv->zv_zso->zvo_queue, zvol_request);
- blk_queue_set_write_cache(zv->zv_zso->zvo_queue, B_TRUE, B_TRUE);
+ blk_queue_set_write_cache(zso->zvo_queue, B_TRUE, B_TRUE);
/* Limit read-ahead to a single page to prevent over-prefetching. */
- blk_queue_set_read_ahead(zv->zv_zso->zvo_queue, 1);
+ blk_queue_set_read_ahead(zso->zvo_queue, 1);
/* Disable write merging in favor of the ZIO pipeline. */
- blk_queue_flag_set(QUEUE_FLAG_NOMERGES, zv->zv_zso->zvo_queue);
+ blk_queue_flag_set(QUEUE_FLAG_NOMERGES, zso->zvo_queue);
- zv->zv_zso->zvo_disk = alloc_disk(ZVOL_MINORS);
- if (zv->zv_zso->zvo_disk == NULL)
+ zso->zvo_disk = alloc_disk(ZVOL_MINORS);
+ if (zso->zvo_disk == NULL)
goto out_queue;
- zv->zv_zso->zvo_queue->queuedata = zv;
- zv->zv_zso->zvo_dev = dev;
+ zso->zvo_queue->queuedata = zv;
+ zso->zvo_dev = dev;
zv->zv_open_count = 0;
strlcpy(zv->zv_name, name, MAXNAMELEN);
zfs_rangelock_init(&zv->zv_rangelock, NULL, NULL);
rw_init(&zv->zv_suspend_lock, NULL, RW_DEFAULT, NULL);
- zv->zv_zso->zvo_disk->major = zvol_major;
- zv->zv_zso->zvo_disk->events = DISK_EVENT_MEDIA_CHANGE;
+ zso->zvo_disk->major = zvol_major;
+ zso->zvo_disk->events = DISK_EVENT_MEDIA_CHANGE;
if (volmode == ZFS_VOLMODE_DEV) {
/*
@@ -808,27 +808,27 @@ zvol_alloc(dev_t dev, const char *name)
* and suppresses partition scanning (GENHD_FL_NO_PART_SCAN)
* setting gendisk->flags accordingly.
*/
- zv->zv_zso->zvo_disk->minors = 1;
+ zso->zvo_disk->minors = 1;
#if defined(GENHD_FL_EXT_DEVT)
- zv->zv_zso->zvo_disk->flags &= ~GENHD_FL_EXT_DEVT;
+ zso->zvo_disk->flags &= ~GENHD_FL_EXT_DEVT;
#endif
#if defined(GENHD_FL_NO_PART_SCAN)
- zv->zv_zso->zvo_disk->flags |= GENHD_FL_NO_PART_SCAN;
+ zso->zvo_disk->flags |= GENHD_FL_NO_PART_SCAN;
#endif
}
- zv->zv_zso->zvo_disk->first_minor = (dev & MINORMASK);
- zv->zv_zso->zvo_disk->fops = &zvol_ops;
- zv->zv_zso->zvo_disk->private_data = zv;
- zv->zv_zso->zvo_disk->queue = zv->zv_zso->zvo_queue;
- snprintf(zv->zv_zso->zvo_disk->disk_name, DISK_NAME_LEN, "%s%d",
+ zso->zvo_disk->first_minor = (dev & MINORMASK);
+ zso->zvo_disk->fops = &zvol_ops;
+ zso->zvo_disk->private_data = zv;
+ zso->zvo_disk->queue = zso->zvo_queue;
+ snprintf(zso->zvo_disk->disk_name, DISK_NAME_LEN, "%s%d",
ZVOL_DEV_NAME, (dev & MINORMASK));
return (zv);
out_queue:
- blk_cleanup_queue(zv->zv_zso->zvo_queue);
+ blk_cleanup_queue(zso->zvo_queue);
out_kmem:
- kmem_free(zv->zv_zso, sizeof (struct zvol_state_os));
+ kmem_free(zso, sizeof (struct zvol_state_os));
kmem_free(zv, sizeof (zvol_state_t));
return (NULL);
}