diff options
| author | Brian Behlendorf <[email protected]> | 2019-12-16 10:55:11 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2019-12-18 17:25:13 -0800 |
| commit | 070402f112bcfbf53b7da9bedc9453721b159e96 (patch) | |
| tree | 1d4bf428bb647fefe22c75c019be614fe172743d /module | |
| parent | fe20400db5564d4478fb039e773dd43c1f546d7b (diff) | |
cppcheck: (warning) Possible null pointer dereference: dnp
The dnp argument can only be set to NULL when the DNODE_DRY_RUN flag
is set. In which case, an early return path will be executed and a
NULL pointer dereference at the given location is impossible. Add
an additional ASSERT to silence the cppcheck warning and document
that dbp must never be NULL at the point in the function.
[module/zfs/dnode.c:1566]: (warning) Possible null pointer deref: dnp
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #9732
Diffstat (limited to 'module')
| -rw-r--r-- | module/zfs/dnode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/module/zfs/dnode.c b/module/zfs/dnode.c index 7a48d4014..c25018fb1 100644 --- a/module/zfs/dnode.c +++ b/module/zfs/dnode.c @@ -1559,6 +1559,7 @@ dnode_hold_impl(objset_t *os, uint64_t object, int flag, int slots, dnode_slots_rele(dnc, idx, slots); DNODE_VERIFY(dn); + ASSERT3P(dnp, !=, NULL); ASSERT3P(dn->dn_dbuf, ==, db); ASSERT3U(dn->dn_object, ==, object); dbuf_rele(db, FTAG); |