summaryrefslogtreecommitdiffstats
path: root/module/zpios
diff options
context:
space:
mode:
authorNed Bass <[email protected]>2013-01-09 15:46:31 -0800
committerBrian Behlendorf <[email protected]>2013-01-09 16:54:52 -0800
commit761394b3af152895ac68a970a91a4f8a917c547b (patch)
tree150fc317c9f41c6a3870072fbe2b3428a0874e8e /module/zpios
parent1c50c992bafd96773dc3950d382a89806df8cc9c (diff)
call_usermodehelper() should wait for process
As of Linux 3.4 the UMH_WAIT_* constants were renumbered. In particular, the meaning of "1" changed from UMH_WAIT_PROC (wait for process to complete), to UMH_WAIT_EXEC (wait for the exec, but not the process). A number of call sites used the number 1 instead of the constant name, so the behavior was not as expected on kernels with this change. One visible consequence of this change was that processes accessing automounted snapshots received an ELOOP error because they failed to wait for zfs.mount to complete. Signed-off-by: Brian Behlendorf <[email protected]> Closes #816
Diffstat (limited to 'module/zpios')
-rw-r--r--module/zpios/pios.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/module/zpios/pios.c b/module/zpios/pios.c
index 6af200570..aa1f2bbd3 100644
--- a/module/zpios/pios.c
+++ b/module/zpios/pios.c
@@ -92,7 +92,7 @@ int zpios_upcall(char *path, char *phase, run_args_t *run_args, int rc)
envp[2] = "PATH=/sbin:/usr/sbin:/bin:/usr/bin";
envp[3] = NULL;
- return call_usermodehelper(path, argv, envp, 1);
+ return call_usermodehelper(path, argv, envp, UMH_WAIT_PROC);
}
static uint64_t