diff options
| author | Ned Bass <[email protected]> | 2017-08-02 21:16:12 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2017-08-02 21:16:12 -0700 |
| commit | ecb2b7dc7f8f7273c215fb30c984bde08e75b852 (patch) | |
| tree | 55e26ef1e29163fba495ba517d8133d475169651 /module/zfs/zfs_ioctl.c | |
| parent | 6710381680b0f551c37627e3a5a4886ccf99983f (diff) | |
Use SET_ERROR for constant non-zero return codes
Update many return and assignment statements to follow the convention
of using the SET_ERROR macro when returning a hard-coded non-zero
value from a function. This aids debugging by recording the error
codes in the debug log.
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Signed-off-by: Ned Bass <[email protected]>
Closes #6441
Diffstat (limited to 'module/zfs/zfs_ioctl.c')
| -rw-r--r-- | module/zfs/zfs_ioctl.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c index 21fefe57f..66311711c 100644 --- a/module/zfs/zfs_ioctl.c +++ b/module/zfs/zfs_ioctl.c @@ -595,7 +595,7 @@ out_check: return (PRIV_POLICY(cr, needed_priv, B_FALSE, EPERM, NULL)); return (0); #else - return (ENOTSUP); + return (SET_ERROR(ENOTSUP)); #endif /* HAVE_MLSLABEL */ } @@ -3652,7 +3652,7 @@ zfs_ioc_destroy(zfs_cmd_t *zc) if (err == 0) err = dsl_destroy_head(zc->zc_name); else if (err == ENOENT) - err = EEXIST; + err = SET_ERROR(EEXIST); } } @@ -6313,7 +6313,7 @@ zfsdev_getminor(struct file *filp, minor_t *minorp) fpd = filp->private_data; if (fpd == NULL) - return (EBADF); + return (SET_ERROR(EBADF)); mutex_enter(&zfsdev_state_lock); @@ -6331,7 +6331,7 @@ zfsdev_getminor(struct file *filp, minor_t *minorp) mutex_exit(&zfsdev_state_lock); - return (EBADF); + return (SET_ERROR(EBADF)); } /* |