diff options
| author | Brian Behlendorf <[email protected]> | 2022-03-23 08:51:00 -0700 |
|---|---|---|
| committer | GitHub <[email protected]> | 2022-03-23 08:51:00 -0700 |
| commit | 460748d4aeb1ed3c78efdd562fcf3d2eaa9ff536 (patch) | |
| tree | 4306b254cee276ba810e507173a0a75d42b9a311 /module/zfs/vdev_trim.c | |
| parent | b73505c7e056417cba73dcf51b49062c84fd2b59 (diff) | |
Switch from _Noreturn to __attribute__((noreturn))
Parts of the Linux kernel build system struggle with _Noreturn. This
results in the following warnings when building on RHEL 8.5, and likely
other environments. Switch to using the __attribute__((noreturn)).
warning: objtool: dbuf_free_range()+0x2b8:
return with modified stack frame
warning: objtool: dbuf_free_range()+0x0:
stack state mismatch: cfa1=7+40 cfa2=7+8
...
WARNING: EXPORT symbol "arc_buf_size" [zfs.ko] version generation
failed, symbol will not be versioned.
WARNING: EXPORT symbol "spa_open" [zfs.ko] version generation
failed, symbol will not be versioned.
...
Additionally, __thread_exit() has been renamed spl_thread_exit() and
made a static inline function. This was needed because the kernel
will generate a warning for symbols which are __attribute__((noreturn))
and then exported with EXPORT_SYMBOL.
While we could continue to use _Noreturn in user space I've also
switched it to __attribute__((noreturn)) purely for consistency
throughout the code base.
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #13238
Diffstat (limited to 'module/zfs/vdev_trim.c')
| -rw-r--r-- | module/zfs/vdev_trim.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/module/zfs/vdev_trim.c b/module/zfs/vdev_trim.c index 43027f136..ed98df782 100644 --- a/module/zfs/vdev_trim.c +++ b/module/zfs/vdev_trim.c @@ -834,7 +834,7 @@ vdev_trim_range_add(void *arg, uint64_t start, uint64_t size) * by its ms_allocatable. While a metaslab is undergoing trimming it is * not eligible for new allocations. */ -static _Noreturn void +static __attribute__((noreturn)) void vdev_trim_thread(void *arg) { vdev_t *vd = arg; @@ -1175,7 +1175,7 @@ vdev_trim_range_verify(void *arg, uint64_t start, uint64_t size) * N.B. This behavior is different from a manual TRIM where a thread * is created for each leaf vdev, instead of each top-level vdev. */ -static _Noreturn void +static __attribute__((noreturn)) void vdev_autotrim_thread(void *arg) { vdev_t *vd = arg; @@ -1514,7 +1514,7 @@ vdev_autotrim_restart(spa_t *spa) vdev_autotrim(spa); } -static _Noreturn void +static __attribute__((noreturn)) void vdev_trim_l2arc_thread(void *arg) { vdev_t *vd = arg; |