summaryrefslogtreecommitdiffstats
path: root/module/zfs/txg.c
diff options
context:
space:
mode:
authorTom Caputi <[email protected]>2018-10-15 15:14:22 -0400
committerBrian Behlendorf <[email protected]>2018-10-24 14:36:50 -0700
commitab4c009e3d0cf794bbe84aff3b9ac203eaed03c7 (patch)
tree1c80fc0bd955e7b5acc9d8f375559e21fd3314bd /module/zfs/txg.c
parentc04812f964a2a79ec501fb1ba995ef333ff79172 (diff)
Fix dbgmsg printing in ztest and zdb
This patch resolves a problem where the -G option in both zdb and ztest would cause the code to call __dprintf() to print zfs_dbgmsg output. This function was not properly wired to add messages to the dbgmsg log as it is in userspace and so the messages were simply dropped. This patch also tries to add some degree of distinction to dprintf() (which now prints directly to stdout) and zfs_dbgmsg() (which adds messages to an internal list that can be dumped with zfs_dbgmsg_print()). In addition, this patch corrects an issue where ztest used a global variable to decide whether to dump the dbgmsg buffer on a crash. This did not work because ztest spins up more instances of itself using execv(), which did not copy the global variable to the new process. The option has been moved to the ztest_shared_opts_t which already exists for interprocess communication. This patch also changes zfs_dbgmsg_print() to use write() calls instead of printf() so that it will not fail when used in a signal handler. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Serapheim Dimitropoulos <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Signed-off-by: Tom Caputi <[email protected]> Closes #8010
Diffstat (limited to 'module/zfs/txg.c')
0 files changed, 0 insertions, 0 deletions