aboutsummaryrefslogtreecommitdiffstats
path: root/module/zfs/metaslab.c
diff options
context:
space:
mode:
authorSerapheim Dimitropoulos <[email protected]>2019-07-30 10:13:44 -0700
committerMatthew Ahrens <[email protected]>2019-07-30 10:13:44 -0700
commit2fcf4481a6f6ff037e24f2926e31fd64a50536da (patch)
tree6c6df43b49079cc8bd162a63fea24ec114448b27 /module/zfs/metaslab.c
parenta6c82894735a476ce5eb275f307ec0b5430296e4 (diff)
mismerged log spacemap comment for metaslab_verify_weight_and_frag
When the log spacemap commit was merged in ZoL, the metaslab_verify_unflushed_changes() debugging function was deleted as the feature was pretty much stable by then. Unfortunately though there was a reference to it from a comment in metaslab_verify_weight_and_frag(). This patch deletes the reference and pastes that comment as is. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matt Ahrens <[email protected]> Reviewed-by: Igor Kozhukhov <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Serapheim Dimitropoulos <[email protected]> Closes #9097
Diffstat (limited to 'module/zfs/metaslab.c')
-rw-r--r--module/zfs/metaslab.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c
index 20884d02c..02b913780 100644
--- a/module/zfs/metaslab.c
+++ b/module/zfs/metaslab.c
@@ -1639,7 +1639,15 @@ metaslab_verify_weight_and_frag(metaslab_t *msp)
if ((zfs_flags & ZFS_DEBUG_METASLAB_VERIFY) == 0)
return;
- /* see comment in metaslab_verify_unflushed_changes() */
+ /*
+ * We can end up here from vdev_remove_complete(), in which case we
+ * cannot do these assertions because we hold spa config locks and
+ * thus we are not allowed to read from the DMU.
+ *
+ * We check if the metaslab group has been removed and if that's
+ * the case we return immediately as that would mean that we are
+ * here from the aforementioned code path.
+ */
if (msp->ms_group == NULL)
return;