diff options
| author | Serapheim Dimitropoulos <[email protected]> | 2018-06-12 15:34:20 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2018-06-21 09:35:26 -0700 |
| commit | 7637ef8d235f34876c8600e3006e0bb9763b24d8 (patch) | |
| tree | 5409fba0385b200e6ed6353821f518b92f2ffd02 /module/zfs/dnode_sync.c | |
| parent | af43029484cc368112954668dace8fa9327f72f2 (diff) | |
OpenZFS 9591 - ms_shift can be incorrectly changed
ms_shift can be incorrectly changed changed in MOS config for
indirect vdevs that have been historically expanded
According to spa_config_update() we expect new vdevs to have
vdev_ms_array equal to 0 and then we go ahead and set their metaslab
size. The problem is that indirect vdevs also have vdev_ms_array == 0
because their metaslabs are destroyed once their removal is done.
As a result, if a vdev was expanded and then removed may have its
ms_shift changed if another vdev was added after its removal.
Fortunately this behavior does not cause any type of crash or bad
behavior in the kernel but it can confuse zdb and anyone doing any kind
of analysis of the history of the pools.
Authored by: Serapheim Dimitropoulos <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: John Kennedy <[email protected]>
Reviewed by: Prashanth Sreenivasa <[email protected]>
Reviewed by: Brian Behlendorf <[email protected]>
Signed-off-by: Tim Chase <[email protected]>
Ported-by: Tim Chase <[email protected]>
OpenZFS-commit: https://github.com/openzfs/openzfs/pull/651
OpenZFS-issue: https://illumos.org/issues/9591a
External-issue: DLPX-58879
Closes #7644
Diffstat (limited to 'module/zfs/dnode_sync.c')
0 files changed, 0 insertions, 0 deletions