diff options
| author | Ned Bass <[email protected]> | 2017-08-02 21:16:12 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2017-08-02 21:16:12 -0700 |
| commit | ecb2b7dc7f8f7273c215fb30c984bde08e75b852 (patch) | |
| tree | 55e26ef1e29163fba495ba517d8133d475169651 /module/zfs/dmu_send.c | |
| parent | 6710381680b0f551c37627e3a5a4886ccf99983f (diff) | |
Use SET_ERROR for constant non-zero return codes
Update many return and assignment statements to follow the convention
of using the SET_ERROR macro when returning a hard-coded non-zero
value from a function. This aids debugging by recording the error
codes in the debug log.
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Signed-off-by: Ned Bass <[email protected]>
Closes #6441
Diffstat (limited to 'module/zfs/dmu_send.c')
| -rw-r--r-- | module/zfs/dmu_send.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/module/zfs/dmu_send.c b/module/zfs/dmu_send.c index eb27b5e71..83204563e 100644 --- a/module/zfs/dmu_send.c +++ b/module/zfs/dmu_send.c @@ -370,7 +370,7 @@ dump_write_embedded(dmu_sendarg_t *dsp, uint64_t object, uint64_t offset, if (dsp->dsa_pending_op != PENDING_NONE) { if (dump_record(dsp, NULL, 0) != 0) - return (EINTR); + return (SET_ERROR(EINTR)); dsp->dsa_pending_op = PENDING_NONE; } @@ -390,7 +390,7 @@ dump_write_embedded(dmu_sendarg_t *dsp, uint64_t object, uint64_t offset, decode_embedded_bp_compressed(bp, buf); if (dump_record(dsp, buf, P2ROUNDUP(drrw->drr_psize, 8)) != 0) - return (EINTR); + return (SET_ERROR(EINTR)); return (0); } @@ -2380,15 +2380,15 @@ receive_write_embedded(struct receive_writer_arg *rwa, int err; if (drrwe->drr_offset + drrwe->drr_length < drrwe->drr_offset) - return (EINVAL); + return (SET_ERROR(EINVAL)); if (drrwe->drr_psize > BPE_PAYLOAD_SIZE) - return (EINVAL); + return (SET_ERROR(EINVAL)); if (drrwe->drr_etype >= NUM_BP_EMBEDDED_TYPES) - return (EINVAL); + return (SET_ERROR(EINVAL)); if (drrwe->drr_compression >= ZIO_COMPRESS_FUNCTIONS) - return (EINVAL); + return (SET_ERROR(EINVAL)); tx = dmu_tx_create(rwa->os); |