diff options
| author | Tom Caputi <[email protected]> | 2018-04-10 14:15:05 -0400 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2018-04-10 11:15:05 -0700 |
| commit | edc1e713c294d116702b034c59eed7b9a03fbc64 (patch) | |
| tree | 95423150271705e3015359791785f12221d896ff /module/zfs/dmu.c | |
| parent | 10f88c5cd523eec8431941abf00017fc8fb67fd3 (diff) | |
Fix race in dnode_check_slots_free()
Currently, dnode_check_slots_free() works by checking dn->dn_type
in the dnode to determine if the dnode is reclaimable. However,
there is a small window of time between dnode_free_sync() in the
first call to dsl_dataset_sync() and when the useraccounting code
is run when the type is set DMU_OT_NONE, but the dnode is not yet
evictable, leading to crashes. This patch adds the ability for
dnodes to track which txg they were last dirtied in and adds a
check for this before performing the reclaim.
This patch also corrects several instances when dn_dirty_link was
treated as a list_node_t when it is technically a multilist_node_t.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tom Caputi <[email protected]>
Closes #7147
Closes #7388
Diffstat (limited to 'module/zfs/dmu.c')
| -rw-r--r-- | module/zfs/dmu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/module/zfs/dmu.c b/module/zfs/dmu.c index 2b727372c..64c898198 100644 --- a/module/zfs/dmu.c +++ b/module/zfs/dmu.c @@ -2284,7 +2284,7 @@ dmu_offset_next(objset_t *os, uint64_t object, boolean_t hole, uint64_t *off) * Check if dnode is dirty */ for (i = 0; i < TXG_SIZE; i++) { - if (list_link_active(&dn->dn_dirty_link[i])) { + if (multilist_link_active(&dn->dn_dirty_link[i])) { clean = B_FALSE; break; } |