summaryrefslogtreecommitdiffstats
path: root/module/zfs/bqueue.c
diff options
context:
space:
mode:
authorcao <[email protected]>2016-10-08 04:19:43 +0800
committerBrian Behlendorf <[email protected]>2016-10-07 13:19:43 -0700
commitccc92611b1bd0a78a72f553472a91ef1e83b06c5 (patch)
tree119b75f97b2afab3eeafcbd1fdc81322c0512549 /module/zfs/bqueue.c
parent482cd9ee69e88710e9241fac220501ea4e101d19 (diff)
Fix coverity defects: CID 147565-147567
coverity scan CID:147567, Type:dereference null return value coverity scan CID:147566, Type:dereference null return value coverity scan CID:147565, Type:dereference null return value Reviewed by: Richard Laager <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: cao.xuewen <[email protected]> Closes #5166
Diffstat (limited to 'module/zfs/bqueue.c')
-rw-r--r--module/zfs/bqueue.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/module/zfs/bqueue.c b/module/zfs/bqueue.c
index 89655cf53..0e490805c 100644
--- a/module/zfs/bqueue.c
+++ b/module/zfs/bqueue.c
@@ -87,13 +87,14 @@ bqueue_enqueue(bqueue_t *q, void *data, uint64_t item_size)
void *
bqueue_dequeue(bqueue_t *q)
{
- void *ret;
+ void *ret = NULL;
uint64_t item_size;
mutex_enter(&q->bq_lock);
while (q->bq_size == 0) {
cv_wait(&q->bq_pop_cv, &q->bq_lock);
}
ret = list_remove_head(&q->bq_list);
+ ASSERT3P(ret, !=, NULL);
item_size = obj2node(q, ret)->bqn_size;
q->bq_size -= item_size;
mutex_exit(&q->bq_lock);