summaryrefslogtreecommitdiffstats
path: root/module/zfs/arc.c
diff options
context:
space:
mode:
authortuxoko <[email protected]>2015-10-30 16:10:01 -0700
committerBrian Behlendorf <[email protected]>2015-11-19 16:02:47 -0800
commit43518d92fd9200aa07a871604a682e0dc7dff981 (patch)
tree26d0d567976a35190f0e1c4667671a525238cacc /module/zfs/arc.c
parentd0c614ecf9eb0b5f5c5d75316c2faeff63e03c4e (diff)
Fix zfs_dirty_data_max overflow on 32-bit
On 32 bit, the calculation of zfs_dirty_data_max from phymem will overflow, causing it to be smaller than zfs_dirty_data_sync, and will cause txg being delayed while no one write to disk. The end result is horrendous write speed. On 4G ram 32-bit VM, before this patch, simple dd results in ~7MB/s. Now it can reach speed on par with 64-bit VM. Signed-off-by: Chunwei Chen <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #3973
Diffstat (limited to 'module/zfs/arc.c')
-rw-r--r--module/zfs/arc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/module/zfs/arc.c b/module/zfs/arc.c
index c1e0bfbba..4e7e05924 100644
--- a/module/zfs/arc.c
+++ b/module/zfs/arc.c
@@ -5479,11 +5479,11 @@ arc_init(void)
* zfs_dirty_data_max_max (default 25% of physical memory).
*/
if (zfs_dirty_data_max_max == 0)
- zfs_dirty_data_max_max = physmem * PAGESIZE *
+ zfs_dirty_data_max_max = (uint64_t)physmem * PAGESIZE *
zfs_dirty_data_max_max_percent / 100;
if (zfs_dirty_data_max == 0) {
- zfs_dirty_data_max = physmem * PAGESIZE *
+ zfs_dirty_data_max = (uint64_t)physmem * PAGESIZE *
zfs_dirty_data_max_percent / 100;
zfs_dirty_data_max = MIN(zfs_dirty_data_max,
zfs_dirty_data_max_max);