diff options
| author | Brian Behlendorf <[email protected]> | 2009-10-30 10:55:25 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2009-10-30 10:55:25 -0700 |
| commit | 5e9b5d832b228b0628a61c9c1c9bf0b05d2fe122 (patch) | |
| tree | 8dc52bf67d9cbd60a6bfc41e1156cf80b673126d /module/spl | |
| parent | 2b5adaf18fde25b963a9d21407773544f2cbed6f (diff) | |
Use Linux atomic primitives by default.
Previously Solaris style atomic primitives were implemented simply by
wrapping the desired operation in a global spinlock. This was easy to
implement at the time when I wasn't 100% sure I could safely layer the
Solaris atomic primatives on the Linux counterparts. It however was
likely not good for performance.
After more investigation however it does appear the Solaris primitives
can be layered on Linux's fairly safely. The Linux atomic_t type really
just wraps a long so we can simply cast the Solaris unsigned value to
either a atomic_t or atomic64_t. The only lingering problem for both
implementations is that Solaris provides no atomic read function. This
means reading a 64-bit value on a 32-bit arch can (and will) result in
word breaking. I was very concerned about this initially, but upon
further reflection it is a limitation of the Solaris API. So really
we are just being bug-for-bug compatible here.
With this change the default implementation is layered on top of Linux
atomic types. However, because we're assuming a lot about the internal
implementation of those types I've made it easy to fall-back to the
generic approach. Simply build with --enable-atomic_spinlocks if
issues are encountered with the new implementation.
Diffstat (limited to 'module/spl')
| -rw-r--r-- | module/spl/spl-atomic.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/module/spl/spl-atomic.c b/module/spl/spl-atomic.c index 40cdb06cc..decf9515e 100644 --- a/module/spl/spl-atomic.c +++ b/module/spl/spl-atomic.c @@ -32,9 +32,11 @@ #define DEBUG_SUBSYSTEM S_ATOMIC +#ifdef ATOMIC_SPINLOCK /* Global atomic lock declarations */ -spinlock_t atomic64_lock = SPIN_LOCK_UNLOCKED; spinlock_t atomic32_lock = SPIN_LOCK_UNLOCKED; +spinlock_t atomic64_lock = SPIN_LOCK_UNLOCKED; -EXPORT_SYMBOL(atomic64_lock); EXPORT_SYMBOL(atomic32_lock); +EXPORT_SYMBOL(atomic64_lock); +#endif /* ATOMIC_SPINLOCK */ |