diff options
| author | Mateusz Guzik <[email protected]> | 2020-10-29 17:54:20 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-10-29 09:54:20 -0700 |
| commit | 973ba682f5cbbc8e89683fb439bd0605afc2b43a (patch) | |
| tree | 4c2967ef517ad904f844dc5c9aebf04f62d9b522 /module/os | |
| parent | 082ff328f2582ac32b74e40328c89fe7a74f4dbf (diff) | |
Linux: g/c leftover fence in zfs_znode_alloc
The port removed provisions for zfs_znode_move but the cleanup missed
this bit. To quote the original:
[snip]
list_insert_tail(&zfsvfs->z_all_znodes, zp);
membar_producer();
/*
* Everything else must be valid before assigning z_zfsvfs makes the
* znode eligible for zfs_znode_move().
*/
zp->z_zfsvfs = zfsvfs;
[/snip]
In the current code it is immediately followed by unlock which issues
the same fence, thus plays no role in correctness.
Reviewed-by: Matt Macy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Closes #11115
Diffstat (limited to 'module/os')
| -rw-r--r-- | module/os/linux/zfs/zfs_znode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/module/os/linux/zfs/zfs_znode.c b/module/os/linux/zfs/zfs_znode.c index 69fa3baa7..677c101bc 100644 --- a/module/os/linux/zfs/zfs_znode.c +++ b/module/os/linux/zfs/zfs_znode.c @@ -620,7 +620,6 @@ zfs_znode_alloc(zfsvfs_t *zfsvfs, dmu_buf_t *db, int blksz, mutex_enter(&zfsvfs->z_znodes_lock); list_insert_tail(&zfsvfs->z_all_znodes, zp); zfsvfs->z_nr_znodes++; - membar_producer(); mutex_exit(&zfsvfs->z_znodes_lock); unlock_new_inode(ip); |