diff options
| author | Mateusz Guzik <[email protected]> | 2020-11-02 20:51:12 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-11-02 11:51:12 -0800 |
| commit | 09eb36ce3d98e0eeaeec9c333ac818b2bc3f85bf (patch) | |
| tree | 967d479b3fe081cc9e6cdd2d6ffc4daa412fc7d0 /module/icp | |
| parent | 8583540c6e04135626fe301ace8aa51212826965 (diff) | |
Introduce CPU_SEQID_UNSTABLE
Current CPU_SEQID users don't care about possibly changing CPU ID, but
enclose it within kpreempt disable/enable in order to fend off warnings
from Linux's CONFIG_DEBUG_PREEMPT.
There is no need to do it. The expected way to get CPU ID while allowing
for migration is to use raw_smp_processor_id.
In order to make this future-proof this patch keeps CPU_SEQID as is and
introduces CPU_SEQID_UNSTABLE instead, to make it clear that consumers
explicitly want this behavior.
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Matt Macy <[email protected]>
Signed-off-by: Mateusz Guzik <[email protected]>
Closes #11142
Diffstat (limited to 'module/icp')
| -rw-r--r-- | module/icp/core/kcf_sched.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/module/icp/core/kcf_sched.c b/module/icp/core/kcf_sched.c index 40d50553d..81fd15f8e 100644 --- a/module/icp/core/kcf_sched.c +++ b/module/icp/core/kcf_sched.c @@ -1308,9 +1308,7 @@ kcf_reqid_insert(kcf_areq_node_t *areq) kcf_areq_node_t *headp; kcf_reqid_table_t *rt; - kpreempt_disable(); - rt = kcf_reqid_table[CPU_SEQID & REQID_TABLE_MASK]; - kpreempt_enable(); + rt = kcf_reqid_table[CPU_SEQID_UNSTABLE & REQID_TABLE_MASK]; mutex_enter(&rt->rt_lock); |