diff options
| author | ilovezfs <[email protected]> | 2016-01-28 04:51:19 -0800 |
|---|---|---|
| committer | Tony Hutter <[email protected]> | 2016-10-03 14:51:21 -0700 |
| commit | 125a406e24fbfaec29557e88746210b9f18f646c (patch) | |
| tree | 4007c3d17298909d0470c5c578def45d42f4cd53 /man/man5/zpool-features.5 | |
| parent | 4a2e9a17d5b81ae97b2a1b72437def9ed4996aca (diff) | |
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: Richard Laager <[email protected]>
Approved by: Robert Mustacchi <[email protected]>
Ported by: Tony Hutter <[email protected]>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
Diffstat (limited to 'man/man5/zpool-features.5')
| -rw-r--r-- | man/man5/zpool-features.5 | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/man/man5/zpool-features.5 b/man/man5/zpool-features.5 index dcfb30d18..ffefd4129 100644 --- a/man/man5/zpool-features.5 +++ b/man/man5/zpool-features.5 @@ -464,7 +464,7 @@ improving performance by avoiding the use of spill blocks. l l . GUID org.illumos:sha512 READ\-ONLY COMPATIBLE no -DEPENDENCIES none +DEPENDENCIES extensible_dataset .TE This feature enables the use of the SHA-512/256 truncated hash algorithm @@ -497,7 +497,7 @@ the updated GRUB stage2 module is installed). l l . GUID org.illumos:skein READ\-ONLY COMPATIBLE no -DEPENDENCIES none +DEPENDENCIES extensible_dataset .TE This feature enables the use of the Skein hash algorithm for checksum @@ -533,7 +533,7 @@ error. l l . GUID org.illumos:edonr READ\-ONLY COMPATIBLE no -DEPENDENCIES none +DEPENDENCIES extensible_dataset .TE This feature enables the use of the Edon-R hash algorithm for checksum, |