aboutsummaryrefslogtreecommitdiffstats
path: root/lib/libzpool
diff options
context:
space:
mode:
authorRicardo M. Correia <[email protected]>2010-12-14 09:50:37 -0800
committerBrian Behlendorf <[email protected]>2010-12-14 09:52:46 -0800
commit8d4e8140ef67fa9c8fa0b1d0f5b1d5d36c747969 (patch)
treeced2415e5af0232e7847a6c607b21e8e3196e8cf /lib/libzpool
parenta7dc7e5d5a5c4a68266b3d9ce89c6c53c04b1741 (diff)
Fix block device-related issues in zdb.
Specifically, this fixes the two following errors in zdb when a pool is composed of block devices: 1) 'Value too large for defined data type' when running 'zdb <dataset>'. 2) 'character device required' when running 'zdb -l <block-device>'. Signed-off-by: Ricardo M. Correia <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]>
Diffstat (limited to 'lib/libzpool')
-rw-r--r--lib/libzpool/kernel.c19
1 files changed, 5 insertions, 14 deletions
diff --git a/lib/libzpool/kernel.c b/lib/libzpool/kernel.c
index 6f06f4001..002276a90 100644
--- a/lib/libzpool/kernel.c
+++ b/lib/libzpool/kernel.c
@@ -36,7 +36,6 @@
#include <sys/zfs_context.h>
#include <sys/utsname.h>
#include <sys/time.h>
-#include <sys/mount.h> /* for BLKGETSIZE64 */
#include <sys/systeminfo.h>
/*
@@ -592,22 +591,12 @@ vn_open(char *path, int x1, int flags, int mode, vnode_t **vpp, int x2, int x3)
if (fd == -1)
return (errno);
- if (fstat64(fd, &st) == -1) {
+ if (fstat64_blk(fd, &st) == -1) {
err = errno;
close(fd);
return (err);
}
-#ifdef __linux__
- /* In Linux, use an ioctl to get the size of a block device. */
- if (S_ISBLK(st.st_mode)) {
- if (ioctl(fd, BLKGETSIZE64, &st.st_size) != 0) {
- err = errno;
- close(fd);
- return (err);
- }
- }
-#endif
(void) fcntl(fd, F_SETFD, FD_CLOEXEC);
*vpp = vp = umem_zalloc(sizeof (vnode_t), UMEM_NOFAIL);
@@ -699,10 +688,12 @@ int
fop_getattr(vnode_t *vp, vattr_t *vap)
{
struct stat64 st;
+ int err;
- if (fstat64(vp->v_fd, &st) == -1) {
+ if (fstat64_blk(vp->v_fd, &st) == -1) {
+ err = errno;
close(vp->v_fd);
- return (errno);
+ return (err);
}
vap->va_size = st.st_size;