diff options
author | Brian Behlendorf <[email protected]> | 2015-06-03 11:43:30 -0700 |
---|---|---|
committer | Brian Behlendorf <[email protected]> | 2015-06-25 08:58:16 -0700 |
commit | aa9af22cdf8d16c197974c3a478d2053b3bed498 (patch) | |
tree | 788727837dbf662d4fd5e6551a0e1d3b8d641e0f /lib/libzpool/taskq.c | |
parent | ef56b0780c80ebb0b1e637b8b8c79530a8ab3201 (diff) |
Update all default taskq settings
Over the years the default values for the taskqs used on Linux have
differed slightly from illumos. In the vast majority of cases this
was done to avoid creating an obnoxious number of idle threads which
would pollute the process listing.
With the addition of support for dynamic taskqs all multi-threaded
queues should be created as dynamic taskqs. This allows us to get
the best of both worlds.
* The illumos default values for the I/O pipeline can be restored.
These values are known to work well for most workloads. The only
exception is the zio write interrupt taskq which is changed to
ZTI_P(12, 8). At least under Linux more threads has been shown
to improve performance, see commit 7e55f4e.
* Reduces the number of idle threads on the system when it's not
under heavy load. The maximum number of threads will only be
created when they are required.
* Remove the vdev_file_taskq and rely on the system_taskq instead
which is now dynamic and may have up to 64-threads. Again this
brings us back inline with upstream.
* Tasks dispatched with taskq_dispatch_ent() are allowed to use
dynamic taskqs. The Linux taskq implementation supports this.
Signed-off-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tim Chase <[email protected]>
Closes #3507
Diffstat (limited to 'lib/libzpool/taskq.c')
-rw-r--r-- | lib/libzpool/taskq.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/libzpool/taskq.c b/lib/libzpool/taskq.c index c6fa2fff7..59b4c7c05 100644 --- a/lib/libzpool/taskq.c +++ b/lib/libzpool/taskq.c @@ -178,7 +178,6 @@ taskq_dispatch_ent(taskq_t *tq, task_func_t func, void *arg, uint_t flags, taskq_ent_t *t) { ASSERT(func != NULL); - ASSERT(!(tq->tq_flags & TASKQ_DYNAMIC)); /* * Mark it as a prealloc'd task. This is important |