aboutsummaryrefslogtreecommitdiffstats
path: root/lib/libzpool/kernel.c
diff options
context:
space:
mode:
authorRichard Yao <[email protected]>2014-04-22 23:18:17 -0400
committerBrian Behlendorf <[email protected]>2014-09-23 10:32:45 -0700
commit485c581c41c4da15a17f045605ce5a7562b3b8a2 (patch)
treefbf3828260c5b8a878f6f021dfa364a6e39de037 /lib/libzpool/kernel.c
parent928ee9fe184572a50e686b0c5173edb1b538c627 (diff)
Fix function call with uninitialized value in vdev_inuse
LLVM's static analyzer reported that we could pass an uninitialized pool_guid to spa_by_guid() in vdev_inuse(). Upon review, it is correct. An attempt to repurpose a spare or L2ARC drive from an exported pool will cause the pool_guid passed to spa_by_guid() to be unintialized information from the stack. This will cause non-deterministic behavior. Since there is no reason why we cannot repurpose such disks, we modify vdev_inuse() to avoid calling spa_by_guid() when they are detected. Signed-off-by: Richard Yao <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Issue #2330
Diffstat (limited to 'lib/libzpool/kernel.c')
0 files changed, 0 insertions, 0 deletions