aboutsummaryrefslogtreecommitdiffstats
path: root/lib/libzfs/os
diff options
context:
space:
mode:
authorRyan Moeller <[email protected]>2020-07-11 20:16:13 -0400
committerGitHub <[email protected]>2020-07-11 17:16:13 -0700
commit217f48373f9878a3cd714b8007444f46101aad9e (patch)
tree6adaaedfbc6541a88bda6647a38d33cdb0be4bbd /lib/libzfs/os
parent3933305eaca95ad6c3003765326136d4d710ba0e (diff)
libzfs: Add error message for why creating mountpoint failed
When zfs_mount_at() fails to stat the mountpoint and can't create the directory, we return an error with a message "failed to create mountpoint" but there is no indication why it failed. Add the error string from the syscall to the error aux message. Update do_mount for Linux to return the errno instead of -1. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes #10550
Diffstat (limited to 'lib/libzfs/os')
-rw-r--r--lib/libzfs/os/linux/libzfs_mount_os.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/libzfs/os/linux/libzfs_mount_os.c b/lib/libzfs/os/linux/libzfs_mount_os.c
index 04252e421..7be85097d 100644
--- a/lib/libzfs/os/linux/libzfs_mount_os.c
+++ b/lib/libzfs/os/linux/libzfs_mount_os.c
@@ -569,7 +569,9 @@ do_mount(zfs_handle_t *zhp, const char *mntpt, char *opts, int flags)
}
strlcat(myopts, opts, MNT_LINE_MAX);
zfs_adjust_mount_options(zhp, mntpt, myopts, NULL);
- error = mount(src, mntpt, MNTTYPE_ZFS, mntflags, myopts);
+ if (mount(src, mntpt, MNTTYPE_ZFS, mntflags, myopts)) {
+ return (errno);
+ }
} else {
char *argv[9] = {
"/bin/mount",