aboutsummaryrefslogtreecommitdiffstats
path: root/lib/libzfs/libzfs_pool.c
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2018-11-05 11:53:49 -0800
committerGitHub <[email protected]>2018-11-05 11:53:49 -0800
commit09b85f2dedfae2f15fed3140ffb3246bef36da97 (patch)
treeb89007ad0c5cbf632c6fbb71946b21dcd0b53734 /lib/libzfs/libzfs_pool.c
parente89f1295d4faa88bb05a62c8dd5f781657db5955 (diff)
ztest: reduce gangblock creation
In order to validate the gang block code ztest is configured to artificially force a fraction of large blocks to be written as gang blocks. The default setting chosen for this was to write 25% of all blocks 32k or larger using gang blocks. The confluence of an unrealistically large number of gang blocks, the aggressive fault injection done by ztest, and the split segment reconstruction logic introduced by device removal has resulted in the following type of failure: zdb -bccsv -G -d ... exit code 3 Specifically, zdb was unable to open the pool because it was unable to reconstruct a damaged block. Manual investigation of multiple failures clearly showed that the block could be reconstructed. However, due to the large number of damaged segments (>35) it could not be done in the allotted time. Furthermore, the large number of gang blocks was determined to be the reason for the unrealistically large number of damaged segments. In order to make this situation less likely, this change both increases the forced gang block size to 64k and reduces the frequency to 3% of blocks. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Tom Caputi <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #8080
Diffstat (limited to 'lib/libzfs/libzfs_pool.c')
0 files changed, 0 insertions, 0 deletions