summaryrefslogtreecommitdiffstats
path: root/lib/libspl
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2011-03-21 10:19:30 -0700
committerBrian Behlendorf <[email protected]>2011-03-22 12:14:55 -0700
commitd6bd8eaae4bdbce8e162414bb6c84ac95fd456b4 (patch)
treedeaba214b02403d74f2e8a4dfda04bc08c4bce27 /lib/libspl
parent691f6ac4c2858d64afc2a0dc1bd2b8c041d68502 (diff)
Fix evict() deadlock
Now that KM_SLEEP is not defined as GFP_NOFS there is the possibility of synchronous reclaim deadlocks. These deadlocks never existed in the original OpenSolaris code because all memory reclaim on Solaris is done asyncronously. Linux does both synchronous (direct) and asynchronous (indirect) reclaim. This commit addresses a deadlock caused by inode eviction. A KM_SLEEP allocation may trigger direct memory reclaim and shrink the inode cache. This can occur while a mutex in the array of ZFS_OBJ_HOLD mutexes is held. Through the ->shrink_icache_memory()->evict()->zfs_inactive()-> zfs_zinactive() call path the same mutex may be reacquired resulting in a deadlock. To avoid this deadlock the process must not reacquire the mutex when it is already holding it. This is a reasonable fix for now but longer term the ZFS_OBJ_HOLD mutex locking should be reevaluated. This infrastructure already prevents us from ever using the Linux lock dependency analysis tools, and it may limit scalability.
Diffstat (limited to 'lib/libspl')
0 files changed, 0 insertions, 0 deletions