diff options
| author | GeLiXin <[email protected]> | 2016-10-01 06:47:57 +0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2016-09-30 15:47:57 -0700 |
| commit | 470f12d631764d3706e2702762e9f3ae924cab43 (patch) | |
| tree | 894fe812a83384879dbd595744c35c275f482709 /lib/libshare | |
| parent | ed3ea30fb9341c860c94bf71e771f115ee4801ea (diff) | |
Fix coverity defects: CID 147531 147532 147533 147535
coverity scan CID:147531,type: Argument cannot be negative
- may copy data with negative size
coverity scan CID:147532,type: resource leaks
- may close a fd which is negative
coverity scan CID:147533,type: resource leaks
- may call pwrite64 with a negative size
coverity scan CID:147535,type: resource leaks
- may call fdopen with a negative fd
Reviewed-by: Richard Laager <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: GeLiXin <[email protected]>
Closes #5176
Diffstat (limited to 'lib/libshare')
| -rwxr-xr-x[-rw-r--r--] | lib/libshare/nfs.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/libshare/nfs.c b/lib/libshare/nfs.c index d1b207e65..abcc1025b 100644..100755 --- a/lib/libshare/nfs.c +++ b/lib/libshare/nfs.c @@ -519,6 +519,7 @@ nfs_validate_shareopts(const char *shareopts) static boolean_t nfs_is_share_active(sa_share_impl_t impl_share) { + int fd; char line[512]; char *tab, *cur; FILE *nfs_exportfs_temp_fp; @@ -526,7 +527,10 @@ nfs_is_share_active(sa_share_impl_t impl_share) if (!nfs_available()) return (B_FALSE); - nfs_exportfs_temp_fp = fdopen(dup(nfs_exportfs_temp_fd), "r"); + if ((fd = dup(nfs_exportfs_temp_fd)) == -1) + return (B_FALSE); + + nfs_exportfs_temp_fp = fdopen(fd, "r"); if (nfs_exportfs_temp_fp == NULL || fseek(nfs_exportfs_temp_fp, 0, SEEK_SET) < 0) { |