diff options
author | Brian Behlendorf <[email protected]> | 2018-03-16 16:46:06 -0700 |
---|---|---|
committer | GitHub <[email protected]> | 2018-03-16 16:46:06 -0700 |
commit | a76f3d0437e5e974f0f748f8735af3539443b388 (patch) | |
tree | 8fafdee26e609aaacc7c59825271d569da6ec4eb /lib/libnvpair/Makefile.am | |
parent | 17dd88352e655afe1d09e8e75ca1415e79c3510a (diff) |
Fix deadlock in IO pipeline
In vdev_queue_aggregate() the zio_execute() bypass should not be
called under the vdev queue lock. This can result in a deadlock
as shown in the stack traces below.
Drop the vdev queue lock then walk the parents of the aggregate IO
to determine the list of component IOs to be bypassed. This can
be done safely without holding the io_lock since the new aggregate
IO has not yet been returned and its parents cannot change.
--- THREAD 1 ---
arc_read()
zio_nowait()
zio_vdev_io_start()
vdev_queue_io() <--- mutex_enter(vq->vq_lock)
vdev_queue_io_to_issue()
vdev_queue_aggregate()
zio_execute()
zio_vdev_io_assess()
zio_wait_for_children() <- mutex_enter(zio->io_lock)
--- THREAD 2 --- (inverse order)
arc_read()
zio_change_priority() <- mutex_enter(zio->zio_lock)
vdev_queue_change_io_priority() <- mutex_enter(vq->vq_lock)
Reviewed-by: Tom Caputi <[email protected]>
Reviewed-by: Don Brady <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #7307
Diffstat (limited to 'lib/libnvpair/Makefile.am')
0 files changed, 0 insertions, 0 deletions