diff options
| author | Brian Behlendorf <[email protected]> | 2019-05-23 13:46:33 -0700 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-05-23 13:46:33 -0700 |
| commit | bff2361aeb32a83c26e2992733864ca99cced257 (patch) | |
| tree | ae45cdae978446595bbb160f20dae43ba9e79edb /include | |
| parent | e34c3ee2fcbb320525a110c1811c557bc60479ff (diff) | |
Linux 5.2 compat: rw_tryupgrade()
Commit torvalds/linux@46ad0840b has removed the architecture specific
rwsem source and headers leaving only the generic version. As part
of this change the RWSEM_ACTIVE_READ_BIAS and RWSEM_ACTIVE_WRITE_BIAS
macros were moved to the private kernel/locking/rwsem.h header.
This results in a build failure because these macros were required
to implement the rw_tryupgrade() compatibility function.
In practice, this isn't a major problem because there are only a
few consumers of rw_tryupgrade() and because consumers of rw_tryupgrade
should be written to retry using rw_enter(RW_WRITER).
After auditing all of the callers only dmu_zfetch() was determined
not to perform a retry. It has been updated in this commit to
resolve this issue.
That said, the rw_tryupgrade() functionality should be considered
for possible removal in a future release due to the difficultly
in supporting the interface.
Reviewed-by: Tomohiro Kusumi <[email protected]>
Reviewed-by: Chunwei Chen <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #8730
Diffstat (limited to 'include')
| -rw-r--r-- | include/spl/sys/rwlock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/spl/sys/rwlock.h b/include/spl/sys/rwlock.h index a1c1fd469..408defac2 100644 --- a/include/spl/sys/rwlock.h +++ b/include/spl/sys/rwlock.h @@ -36,7 +36,7 @@ #elif defined(CONFIG_RWSEM_GENERIC_SPINLOCK) #define SPL_RWSEM_SINGLE_READER_VALUE (1) #define SPL_RWSEM_SINGLE_WRITER_VALUE (-1) -#else +#elif defined(RWSEM_ACTIVE_MASK) #define SPL_RWSEM_SINGLE_READER_VALUE (RWSEM_ACTIVE_READ_BIAS) #define SPL_RWSEM_SINGLE_WRITER_VALUE (RWSEM_ACTIVE_WRITE_BIAS) #endif |