diff options
| author | Matthew Ahrens <[email protected]> | 2020-03-03 10:29:38 -0800 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-03-03 10:29:38 -0800 |
| commit | b3212d2fa6ab8d7d8373373e8a6b8acbbf45508e (patch) | |
| tree | 2e5fc480593300e98addaea9959405cf4e4bf7bb /include | |
| parent | 0a0f9a7dc6e4f215089cf0aabb230d5dd5dfbd1e (diff) | |
Improve performance of zio_taskq_member
__zio_execute() calls zio_taskq_member() to determine if we are running
in a zio interrupt taskq, in which case we may need to switch to
processing this zio in a zio issue taskq. The call to
zio_taskq_member() can become a performance bottleneck when we are
processing a high rate of zio's.
zio_taskq_member() calls taskq_member() on each of the zio interrupt
taskqs, of which there are 21. This is slow because each call to
taskq_member() does tsd_get(taskq_tsd), which on Linux is relatively
slow.
This commit improves the performance of zio_taskq_member() by having it
cache the value of tsd_get(taskq_tsd), reducing the number of those
calls to 1/21th of the current behavior.
In a test case running `zfs send -c >/dev/null` of a filesystem with
small blocks (average 2.5KB/block), zio_taskq_member() was using 6.7% of
one CPU, and with this change it is reduced to 1.3%. Overall time to
perform the `zfs send` reduced by 10% (~150,000 block/sec to ~165,000
blocks/sec).
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Serapheim Dimitropoulos <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Tony Nguyen <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #10070
Diffstat (limited to 'include')
| -rw-r--r-- | include/os/linux/spl/sys/taskq.h | 1 | ||||
| -rw-r--r-- | include/sys/zfs_context.h | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/include/os/linux/spl/sys/taskq.h b/include/os/linux/spl/sys/taskq.h index 7353367a2..7a1ee9ec4 100644 --- a/include/os/linux/spl/sys/taskq.h +++ b/include/os/linux/spl/sys/taskq.h @@ -151,6 +151,7 @@ extern void taskq_wait_outstanding(taskq_t *, taskqid_t); extern void taskq_wait(taskq_t *); extern int taskq_cancel_id(taskq_t *, taskqid_t); extern int taskq_member(taskq_t *, kthread_t *); +extern taskq_t *taskq_of_curthread(void); #define taskq_create_proc(name, nthreads, pri, min, max, proc, flags) \ taskq_create(name, nthreads, pri, min, max, flags) diff --git a/include/sys/zfs_context.h b/include/sys/zfs_context.h index 5a67ca677..39c778b1e 100644 --- a/include/sys/zfs_context.h +++ b/include/sys/zfs_context.h @@ -494,6 +494,7 @@ extern void taskq_wait(taskq_t *); extern void taskq_wait_id(taskq_t *, taskqid_t); extern void taskq_wait_outstanding(taskq_t *, taskqid_t); extern int taskq_member(taskq_t *, kthread_t *); +extern taskq_t *taskq_of_curthread(void); extern int taskq_cancel_id(taskq_t *, taskqid_t); extern void system_taskq_init(void); extern void system_taskq_fini(void); |