diff options
| author | Alexander Motin <[email protected]> | 2020-02-13 14:20:42 -0500 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-02-13 11:20:42 -0800 |
| commit | 465e4e795ee3cbdc5de862b26d81b2f1116733df (patch) | |
| tree | 0848a222d5ae27a1a623856540aca148ff3c031a /include | |
| parent | 610eec452d723bc53ce531095aff9577a2e0dc93 (diff) | |
Remove duplicate dbufs accounting
Since AVL already has embedded element counter, use dn_dbufs_count
only for dbufs not counted there (bonus buffers) and just add them.
This removes two atomics per dbuf life cycle.
According to profiler it reduces time spent by dbuf_destroy() inside
bottlenecked dbuf_evict_thread() from 13.36% to 9.20% of the core.
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Matt Ahrens <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored-By: iXsystems, Inc.
Closes #9949
Diffstat (limited to 'include')
| -rw-r--r-- | include/sys/dnode.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/include/sys/dnode.h b/include/sys/dnode.h index 5e9d070e2..708e5fc44 100644 --- a/include/sys/dnode.h +++ b/include/sys/dnode.h @@ -373,6 +373,13 @@ struct dnode { }; /* + * Since AVL already has embedded element counter, use dn_dbufs_count + * only for dbufs not counted there (bonus buffers) and just add them. + */ +#define DN_DBUFS_COUNT(dn) ((dn)->dn_dbufs_count + \ + avl_numnodes(&(dn)->dn_dbufs)) + +/* * We use this (otherwise unused) bit to indicate if the value of * dn_next_maxblkid[txgoff] is valid to use in dnode_sync(). */ |