summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorcao <[email protected]>2016-11-10 09:35:26 +0800
committerBrian Behlendorf <[email protected]>2016-11-09 17:35:26 -0800
commit3bfd95d5898b1318f9a5c36d1cc43cf23d004f64 (patch)
tree69b6824b5fa16153be094a5242456e00c80f0b08 /include
parent7e5ea7be7f69231b66c1affddb870fcea8c3a4d8 (diff)
Fix coverity defects: CID 147540, 147542
CID 147540: unsigned_compare - Cast nsec to a int32_t to properly detect the expected overflow. CID 147542: unsigned_compare - intval can never be less than ZIO_FAILURE_MODE_WAIT which is defined to be zero. Remove this useless check. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: cao.xuewen <[email protected]> Closes #5379
Diffstat (limited to 'include')
-rw-r--r--include/zpios-ctl.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/zpios-ctl.h b/include/zpios-ctl.h
index aee4f0a50..90efcb1b1 100644
--- a/include/zpios-ctl.h
+++ b/include/zpios-ctl.h
@@ -146,7 +146,7 @@ zpios_timespec_normalize(zpios_timespec_t *ts, uint32_t sec, uint32_t nsec)
nsec -= NSEC_PER_SEC;
sec++;
}
- while (nsec < 0) {
+ while (((int32_t)nsec) < 0) {
nsec += NSEC_PER_SEC;
sec--;
}