diff options
| author | Ned Bass <[email protected]> | 2013-01-14 13:59:14 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2013-01-16 16:28:54 -0800 |
| commit | f1a05fa11484d67161606fd1ecf50bf2abc25ced (patch) | |
| tree | 674f566861abf0ab8005ca1d6eebfaeddc0ac54f /include | |
| parent | 94a9bb4709111f5fadb434cce1af6ccb6534e241 (diff) | |
Fix false ENOENT on snapshot control dentries
Lookups in the snapshot control directory for an existing snapshot
fail with ENOENT if an earlier lookup failed before the snapshot was
created. This is because the earlier lookup causes a negative dentry
to be cached which is never invalidated.
The bug can be reproduced as follows (the second ls should succeed):
$ ls /tank/.zfs/snapshot/s
ls: cannot access /tank/.zfs/snapshot/s: No such file or directory
$ zfs snap tank@s
$ ls /tank/.zfs/snapshot/s
ls: cannot access /tank/.zfs/snapshot/s: No such file or directory
To remedy this, always invalidate cached dentries in the snapshot
control directory. Since these entries never exist on disk there is
no significant performance penalty for the extra lookups.
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #1192
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/dcache_compat.h | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/include/linux/dcache_compat.h b/include/linux/dcache_compat.h index a42356276..271a0cbef 100644 --- a/include/linux/dcache_compat.h +++ b/include/linux/dcache_compat.h @@ -35,4 +35,29 @@ #define d_make_root(inode) d_alloc_root(inode) #endif /* HAVE_D_MAKE_ROOT */ +/* + * 2.6.30 API change, + * The const keyword was added to the 'struct dentry_operations' in + * the dentry structure. To handle this we define an appropriate + * dentry_operations_t typedef which can be used. + */ +#ifdef HAVE_CONST_DENTRY_OPERATIONS +typedef const struct dentry_operations dentry_operations_t; +#else +typedef struct dentry_operations dentry_operations_t; +#endif + +/* + * 2.6.38 API change, + * Added d_set_d_op() helper function which sets some flags in + * dentry->d_flags based on which operations are defined. + */ +#ifndef HAVE_D_SET_D_OP +static inline void +d_set_d_op(struct dentry *dentry, dentry_operations_t *op) +{ + dentry->d_op = op; +} +#endif /* HAVE_D_SET_D_OP */ + #endif /* _ZFS_DCACHE_H */ |