diff options
| author | George Wilson <[email protected]> | 2019-08-13 08:11:57 -0600 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2019-08-13 08:11:57 -0600 |
| commit | c8242a96ba8495013cc2f2e12ea6202e61796462 (patch) | |
| tree | 89367092fe6fde1942c7cf6d05721ce40807e3fc /include | |
| parent | a43570c5f3ca11957c23b4e073a520963cd9cfb2 (diff) | |
spa_load_verify() may consume too much memory
When a pool is imported it will scan the pool to verify the integrity
of the data and metadata. The amount it scans will depend on the
import flags provided. On systems with small amounts of memory or
when importing a pool from the crash kernel, it's possible for
spa_load_verify to issue too many I/Os that it consumes all the memory
of the system resulting in an OOM message or a hang.
To prevent this, we limit the amount of memory that the initial pool
scan can consume. This change will, by default, use 1/16th of the ARC
for scan I/Os to prevent running the system out of memory during import.
Reviewed-by: Matt Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Serapheim Dimitropoulos <[email protected]>
Signed-off-by: George Wilson [email protected]
External-issue: DLPX-65237
External-issue: DLPX-65238
Closes #9146
Diffstat (limited to 'include')
| -rw-r--r-- | include/sys/spa_impl.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/sys/spa_impl.h b/include/sys/spa_impl.h index ebe14dae4..503600c8c 100644 --- a/include/sys/spa_impl.h +++ b/include/sys/spa_impl.h @@ -272,7 +272,9 @@ struct spa { boolean_t spa_extreme_rewind; /* rewind past deferred frees */ kmutex_t spa_scrub_lock; /* resilver/scrub lock */ uint64_t spa_scrub_inflight; /* in-flight scrub bytes */ - uint64_t spa_load_verify_ios; /* in-flight verification IOs */ + + /* in-flight verification bytes */ + uint64_t spa_load_verify_bytes; kcondvar_t spa_scrub_io_cv; /* scrub I/O completion */ uint8_t spa_scrub_active; /* active or suspended? */ uint8_t spa_scrub_type; /* type of scrub we're doing */ |