diff options
| author | Matthew Ahrens <[email protected]> | 2020-09-04 10:29:39 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2020-09-09 10:25:59 -0700 |
| commit | bd724261d20192968c6d1e17ea809102aa0de3a0 (patch) | |
| tree | 28c48f51a1b51f7d0c166d801f949cd8cb6547ce /include | |
| parent | a1e03186fdcbf414548e700ecdabcc8867106e6a (diff) | |
nowait synctask must succeed
If a `zfs_space_check_t` other than `ZFS_SPACE_CHECK_NONE` is used with
`dsl_sync_task_nowait()`, the sync task may fail due to ENOSPC.
However, there is no way to notice or communicate this failure, so it's
extremely difficult to use this functionality correctly, and in fact
almost all callers use `ZFS_SPACE_CHECK_NONE`.
This commit removes the `zfs_space_check_t` argument from
`dsl_sync_task_nowait()`, and always uses `ZFS_SPACE_CHECK_NONE`.
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Matthew Ahrens <[email protected]>
Closes #10855
Diffstat (limited to 'include')
| -rw-r--r-- | include/sys/dsl_synctask.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/sys/dsl_synctask.h b/include/sys/dsl_synctask.h index 957963ffe..0bb602e8f 100644 --- a/include/sys/dsl_synctask.h +++ b/include/sys/dsl_synctask.h @@ -112,11 +112,11 @@ void dsl_sync_task_sync(dsl_sync_task_t *, dmu_tx_t *); int dsl_sync_task(const char *, dsl_checkfunc_t *, dsl_syncfunc_t *, void *, int, zfs_space_check_t); void dsl_sync_task_nowait(struct dsl_pool *, dsl_syncfunc_t *, - void *, int, zfs_space_check_t, dmu_tx_t *); + void *, dmu_tx_t *); int dsl_early_sync_task(const char *, dsl_checkfunc_t *, dsl_syncfunc_t *, void *, int, zfs_space_check_t); void dsl_early_sync_task_nowait(struct dsl_pool *, dsl_syncfunc_t *, - void *, int, zfs_space_check_t, dmu_tx_t *); + void *, dmu_tx_t *); int dsl_sync_task_sig(const char *, dsl_checkfunc_t *, dsl_syncfunc_t *, dsl_sigfunc_t *, void *, int, zfs_space_check_t); |