diff options
| author | Chunwei Chen <[email protected]> | 2016-07-05 17:24:36 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2016-07-12 14:18:10 -0700 |
| commit | 31b6111fd92a6bc79a34cb18fd919a29c407ff67 (patch) | |
| tree | fc3e8cb46d98cfcefe55cb1bb7a47d26a1ed0a0b /include/sys | |
| parent | ddae16a9cf0ba84fab4f7f4542efaf68dc87415b (diff) | |
Kill zp->z_xattr_parent to prevent pinning
zp->z_xattr_parent will pin the parent. This will cause huge issue
when unlink a file with xattr. Because the unlinked file is pinned, it
will never get purged immediately. And because of that, the xattr
stuff will never be marked as unlinked. So the whole unlinked stuff
will stay there until shrink cache or umount.
This change partially reverts e89260a. This is safe because only the
zp->z_xattr_parent optimization is removed, zpl_xattr_security_init()
is still called from the zpl outside the inode lock.
Signed-off-by: Chunwei Chen <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chris Dunlop <[email protected]>
Issue #4359
Issue #3508
Issue #4413
Issue #4827
Diffstat (limited to 'include/sys')
| -rw-r--r-- | include/sys/zfs_znode.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/sys/zfs_znode.h b/include/sys/zfs_znode.h index 8e563a572..661628698 100644 --- a/include/sys/zfs_znode.h +++ b/include/sys/zfs_znode.h @@ -197,7 +197,6 @@ typedef struct znode { zfs_acl_t *z_acl_cached; /* cached acl */ krwlock_t z_xattr_lock; /* xattr data lock */ nvlist_t *z_xattr_cached; /* cached xattrs */ - struct znode *z_xattr_parent; /* xattr parent znode */ list_node_t z_link_node; /* all znodes in fs link */ sa_handle_t *z_sa_hdl; /* handle to sa data */ boolean_t z_is_sa; /* are we native sa? */ |