diff options
author | HÃ¥kan Johansson <[email protected]> | 2016-12-01 01:46:16 +0100 |
---|---|---|
committer | Brian Behlendorf <[email protected]> | 2016-11-30 17:46:16 -0700 |
commit | 5f20c145df3ca45f86cd1892137edb117d4c8a82 (patch) | |
tree | 9d05ea43af2ac1fc82ee2964b3611d1e20d8f1bb /include/sys | |
parent | a3fd9d9e1525d5df18b7f8c2895270689d292ec2 (diff) |
Do not force VDEV_NAME_TYPE_ID in max_width()
Do not force VDEV_NAME_TYPE_ID in max_width(), instead add it
in the relevant calls to max_width().
The first location of max_width() where VDEV_NAME_TYPE_ID is
now added in show_import() is followed by print_import_config() and
print_logs(). Both these print children vdev names that have been
retrieved using an explicit VDEV_NAME_TYPE_ID added.
The second location is in status_callback(). This is followed by
print_status_config(), print_logs(), print_l2cache(), and
print_spares(). For l2cache and spares it should not matter as there
are no mirror-X or raidz-X involved. print_status_config() as above
retrieves the name using explicit VDEV_NAME_TYPE_ID before
calling itself to print children.
The call of max_width() in get_namewidth() is not changed, as this is
used by zpool_do_iostat(), followed by print_iostat(), which does not
add VDEV_NAME_TYPE_ID.
Overall, we should consider adding VDEV_NAME_TYPE_ID to the
relevant name_flags / cb_name_flags fields, and remove the explicit
adding in called routines.
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Haakan T Johansson <[email protected]>
Closes #5401
Diffstat (limited to 'include/sys')
0 files changed, 0 insertions, 0 deletions