aboutsummaryrefslogtreecommitdiffstats
path: root/include/sys
diff options
context:
space:
mode:
authorBrian Behlendorf <[email protected]>2009-05-20 15:30:13 -0700
committerBrian Behlendorf <[email protected]>2009-05-20 15:30:13 -0700
commit124ca8a5a98a5e64e6a221b5f30c48361dac6f24 (patch)
tree8e7fdafa9a1bd995ba0f6e55ee3474143f01553d /include/sys
parent5232d256b45b3c48dd96d30b5907c0205192197b (diff)
SLES10 Fixes (part 7)
- Initial SLES testing uncovered a long standing bug in the debug tracing. The tcd_for_each() macro expected a NULL to terminate the trace_data[i] array but this was only ever true due to luck. All trace_data[] iterators are now properly capped by TCD_TYPE_MAX. - SPLAT_MAJOR 229 conflicted with a 'hvc' device on my SLES system. Since this was always an arbitrary choice I picked something else. - The HAVE_PGDAT_LIST case should set pgdat_list_addr to the value stored at the address of the memory location returned by kallsyms_lookup_name().
Diffstat (limited to 'include/sys')
-rw-r--r--include/sys/debug.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/sys/debug.h b/include/sys/debug.h
index 7ceb571d0..12226a033 100644
--- a/include/sys/debug.h
+++ b/include/sys/debug.h
@@ -173,12 +173,12 @@ union trace_data_union {
extern union trace_data_union (*trace_data[TCD_TYPE_MAX])[NR_CPUS];
#define tcd_for_each(tcd, i, j) \
- for (i = 0; trace_data[i] != NULL; i++) \
+ for (i = 0; i < TCD_TYPE_MAX; i++) \
for (j = 0, ((tcd) = &(*trace_data[i])[j].tcd); \
j < num_possible_cpus(); j++, (tcd) = &(*trace_data[i])[j].tcd)
#define tcd_for_each_type_lock(tcd, i, cpu) \
- for (i = 0; trace_data[i] && \
+ for (i = 0; i < TCD_TYPE_MAX && trace_data[i] && \
(tcd = &(*trace_data[i])[cpu].tcd) && \
trace_lock_tcd(tcd); trace_unlock_tcd(tcd), i++)