diff options
| author | Alexander Motin <[email protected]> | 2014-07-18 08:53:38 -0800 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2015-07-06 09:34:13 -0700 |
| commit | e16b3fcc610fab2dcf3381486b2640dc2a2213cb (patch) | |
| tree | 8571cd7ae1db3137b7f36ae93ff07f447a16fecc /include/sys/zfs_znode.h | |
| parent | 4bda3bd0e72d582a785b6552ce16b99e04414fbe (diff) | |
Illumos 5008 - lock contention (rrw_exit) while running a read only load
5008 lock contention (rrw_exit) while running a read only load
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: George Wilson <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Reviewed by: Christopher Siden <[email protected]>
Reviewed by: Richard Yao <[email protected]>
Reviewed by: Saso Kiselkov <[email protected]>
Approved by: Garrett D'Amore <[email protected]>
Porting notes:
This patch ported perfectly cleanly to ZoL. During testing 100% cached
small-block reads, extreme contention was noticed on rrl->rr_lock from
rrw_exit() due to the frequent entering and leaving ZPL. Illumos picked
up this patch from FreeBSD and it also helps under Linux.
On a 1-minute 4K cached read test with 10 fio processes pinned to a single
socket on a 4-socket (10 thread per socket) NUMA system, contentions on
rrl->rr_lock were reduced from 508799 to 43085.
Ported-by: Tim Chase <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #3555
Diffstat (limited to 'include/sys/zfs_znode.h')
| -rw-r--r-- | include/sys/zfs_znode.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/sys/zfs_znode.h b/include/sys/zfs_znode.h index 79ca4f7e9..7e73cf991 100644 --- a/include/sys/zfs_znode.h +++ b/include/sys/zfs_znode.h @@ -250,7 +250,7 @@ typedef struct znode { /* Called on entry to each ZFS vnode and vfs operation */ #define ZFS_ENTER(zsb) \ { \ - rrw_enter_read(&(zsb)->z_teardown_lock, FTAG); \ + rrm_enter_read(&(zsb)->z_teardown_lock, FTAG); \ if ((zsb)->z_unmounted) { \ ZFS_EXIT(zsb); \ return (EIO); \ @@ -260,7 +260,7 @@ typedef struct znode { /* Must be called before exiting the vop */ #define ZFS_EXIT(zsb) \ { \ - rrw_exit(&(zsb)->z_teardown_lock, FTAG); \ + rrm_exit(&(zsb)->z_teardown_lock, FTAG); \ } /* Verifies the znode is valid */ |