diff options
| author | Sara Hartse <[email protected]> | 2019-04-04 18:57:06 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2019-04-04 18:57:06 -0700 |
| commit | a887d653b32aaba3fe04c7b25ff0091b9ea9c64e (patch) | |
| tree | 6d0bd45a6d2080fce9223ae252f5c93782418dd7 /include/spl/sys/debug.h | |
| parent | af6507930051e9ee481cad1130df84636c4a770c (diff) | |
Restrict kstats and print real pointers
There are several places where we use zfs_dbgmsg and %p to
print pointers. In the Linux kernel, these values obfuscated
to prevent information leaks which means the pointers aren't
very useful for debugging crash dumps. We decided to restrict
the permissions of dbgmsg (and some other kstats while we were
at it) and print pointers with %px in zfs_dbgmsg as well as
spl_dumpstack
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Gallagher <[email protected]>
Signed-off-by: sara hartse <[email protected]>
Closes #8467
Closes #8476
Diffstat (limited to 'include/spl/sys/debug.h')
| -rw-r--r-- | include/spl/sys/debug.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/spl/sys/debug.h b/include/spl/sys/debug.h index d9336c7d1..b17d77d28 100644 --- a/include/spl/sys/debug.h +++ b/include/spl/sys/debug.h @@ -102,7 +102,7 @@ void spl_dumpstack(void); if (!(_verify3_left OP _verify3_right)) \ spl_panic(__FILE__, __FUNCTION__, __LINE__, \ "VERIFY3(" #LEFT " " #OP " " #RIGHT ") " \ - "failed (%p " #OP " %p)\n", \ + "failed (%px" #OP " %px)\n", \ (void *) (_verify3_left), \ (void *) (_verify3_right)); \ } while (0) |