diff options
author | Damian Szuberski <[email protected]> | 2021-11-30 19:23:10 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2021-11-30 10:23:10 -0800 |
commit | 34eef3e9a7a74d24a59d016051d547afc55dbaa0 (patch) | |
tree | c75ff6fda4ee9582ed2ebb5b1a71a529242c3d78 /etc | |
parent | 4325de09cd2993837bc32a83d61872b57e58298e (diff) |
Pass `--enable=all` to shellcheck within contrib/
- Remove `SHELLCHECK_IGNORE` in favor of inline suppressions
and more general `SHELLCHECK_OPTS`.
- Exclude `SC2250` (turned on by `--enable=all`) globally
- Pass `--enable=all` to shellcheck for scripts in contrib/: it's
very important to catch errors early in areas that are not easily
testable.
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes #12760
Diffstat (limited to 'etc')
-rw-r--r-- | etc/default/Makefile.am | 1 | ||||
-rw-r--r-- | etc/default/zfs.in | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/etc/default/Makefile.am b/etc/default/Makefile.am index b88eb5494..0f7c96698 100644 --- a/etc/default/Makefile.am +++ b/etc/default/Makefile.am @@ -6,4 +6,3 @@ initconf_SCRIPTS = zfs SUBSTFILES += $(initconf_SCRIPTS) SHELLCHECK_SHELL = sh -SHELLCHECK_IGNORE = ,SC2034 diff --git a/etc/default/zfs.in b/etc/default/zfs.in index 3b6e5486d..93d98058e 100644 --- a/etc/default/zfs.in +++ b/etc/default/zfs.in @@ -8,6 +8,7 @@ # To enable a boolean setting, set it to yes, on, true, or 1. # Anything else will be interpreted as unset. +# shellcheck disable=SC2034 # Run `zfs mount -a` during system start? ZFS_MOUNT='yes' |