diff options
| author | Brian Behlendorf <[email protected]> | 2010-07-12 12:38:34 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2010-07-13 16:44:02 -0700 |
| commit | a4bfd8ea1b58d8797ec91b18982de243675e63bc (patch) | |
| tree | 7506e0415944aa3c689610753900cbe0d143cf53 /config | |
| parent | d466208f1e76c80fe14751739273b1932c4329f3 (diff) | |
Add __divdi3(), remove __udivdi3() kernel dependency
Up until now no SPL consumer attempted to perform signed 64-bit
division so there was no need to support this. That has now
changed so I adding 64-bit division support for 32-bit platforms.
The signed implementation is based on the unsigned version.
Since the have been several bug reports in the past concerning
correct 64-bit division on 32-bit platforms I added some long
over due regression tests. Much to my surprise the unsigned
64-bit division regression tests failed.
This was surprising because __udivdi3() was implemented by simply
calling div64_u64() which is provided by the kernel. This meant
that the linux kernels 64-bit division algorithm on 32-bit platforms
was flawed. After some investigation this turned out to be exactly
the case.
Because of this I was forced to abandon the kernel helper and
instead to fully implement 64-bit division in the spl. There are
several published implementation out there on how to do this
properly and I settled on one proposed in the book Hacker's Delight.
Their proposed algoritm is freely available without restriction
and I have just modified it to be linux kernel friendly.
The update implementation now passed all the unsigned and signed
regression tests. This should be functional, but not fast, which is
good enough for out purposes. If you want fast too I'd strongly
suggest you upgrade to a 64-bit platform. I have also reported the
kernel bug and we'll see if we can't get it fixed up stream.
Diffstat (limited to 'config')
| -rw-r--r-- | config/spl-build.m4 | 28 |
1 files changed, 0 insertions, 28 deletions
diff --git a/config/spl-build.m4 b/config/spl-build.m4 index 7fd403f89..ae4e1f162 100644 --- a/config/spl-build.m4 +++ b/config/spl-build.m4 @@ -53,8 +53,6 @@ AC_DEFUN([SPL_AC_CONFIG_KERNEL], [ SPL_AC_INODE_I_MUTEX SPL_AC_MUTEX_OWNER SPL_AC_MUTEX_LOCK_NESTED - SPL_AC_DIV64_64 - SPL_AC_DIV64_U64 SPL_AC_3ARGS_ON_EACH_CPU SPL_AC_KALLSYMS_LOOKUP_NAME SPL_AC_GET_VMALLOC_INFO @@ -951,32 +949,6 @@ AC_DEFUN([SPL_AC_MUTEX_LOCK_NESTED], [ ]) dnl # -dnl # 2.6.22 API change, -dnl # First introduced 'div64_64()' in lib/div64.c -dnl -AC_DEFUN([SPL_AC_DIV64_64], [ - SPL_CHECK_SYMBOL_EXPORT( - [div64_64], - [], - [AC_DEFINE(HAVE_DIV64_64, 1, - [div64_64() is available])], - []) -]) - -dnl # -dnl # 2.6.26 API change, -dnl # Renamed 'div64_64()' to 'div64_u64' in lib/div64.c -dnl # -AC_DEFUN([SPL_AC_DIV64_U64], [ - SPL_CHECK_SYMBOL_EXPORT( - [div64_u64], - [], - [AC_DEFINE(HAVE_DIV64_U64, 1, - [div64_u64() is available])], - []) -]) - -dnl # dnl # 2.6.27 API change, dnl # on_each_cpu() uses 3 args, no 'retry' argument dnl # |