diff options
| author | Rob N <[email protected]> | 2023-07-22 04:53:06 +1000 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2023-07-21 16:35:12 -0700 |
| commit | c5273e0c317a941af9c8a4090ad38b1c7b55d716 (patch) | |
| tree | e59d7ef84e99ed633b69b9a3e896a20baae1496f /config | |
| parent | 685ae4429ffe7753359faa6cbae34e061d1e670b (diff) | |
shellcheck: disable "unreachable command" check [SC2317]
This new check in 0.9.0 appears to have some issues with various forms
of "early return", like trap, exit and return. This is tripping up (at
least):
cmd/zed/zed.d/history_event-zfs-list-cacher.sh
/etc/zfs/zfs-functions
Its not obvious what its complaining about or what the remedy is, so it
seems sensible to disable this check for now.
See also:
https://www.shellcheck.net/wiki/SC2317
https://github.com/koalaman/shellcheck/issues/2542
https://github.com/koalaman/shellcheck/issues/2613
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #15089
Diffstat (limited to 'config')
| -rw-r--r-- | config/Shellcheck.am | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/config/Shellcheck.am b/config/Shellcheck.am index 1cff81e04..1ab135160 100644 --- a/config/Shellcheck.am +++ b/config/Shellcheck.am @@ -4,6 +4,7 @@ # Not following: a was not specified as input (see shellcheck -x). [SC1091] # Prefer putting braces around variable references even when not strictly required. [SC2250] # Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). [SC2312] +# Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317] # In POSIX sh, 'local' is undefined. [SC2039] # older ShellCheck versions # In POSIX sh, 'local' is undefined. [SC3043] # newer ShellCheck versions @@ -18,7 +19,7 @@ PHONY += shellcheck _STGT = $(subst ^,/,$(subst shellcheck-here-,,$@)) shellcheck-here-%: if HAVE_SHELLCHECK - shellcheck --format=gcc --enable=all --exclude=SC1090,SC1091,SC2039,SC2250,SC2312,SC3043 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") "$$([ -e "$(_STGT)" ] || echo "$(srcdir)/")$(_STGT)" + shellcheck --format=gcc --enable=all --exclude=SC1090,SC1091,SC2039,SC2250,SC2312,SC2317,SC3043 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") "$$([ -e "$(_STGT)" ] || echo "$(srcdir)/")$(_STGT)" else @echo "skipping shellcheck of" $(_STGT) "because shellcheck is not installed" endif |