aboutsummaryrefslogtreecommitdiffstats
path: root/config/kernel-create-nameidata.m4
diff options
context:
space:
mode:
authorchrisrd <[email protected]>2018-02-16 07:58:23 +1100
committerBrian Behlendorf <[email protected]>2018-02-15 12:58:23 -0800
commite921f6508b212c61fcedd0eeb2f9cf9da1abc4d1 (patch)
tree1eb47661e8e4f048f29dfc93e028d27bda0c7652 /config/kernel-create-nameidata.m4
parent62d5c5531334c25918dad7f2b303eefe33da4f5a (diff)
Fix config issues: frame size and headers
1. With various (debug and/or tracing?) kernel options enabled it's possible for 'struct inode' and 'struct super_block' to exceed the default frame size, leaving errors like this in config.log: build/conftest.c:116:1: error: the frame size of 1048 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] Fix this by removing the frame size warning for config checks 2. Without the correct headers included, it's possible for declarations to be missed, leaving errors like this in the config.log: build/conftest.c:131:14: error: ‘struct nameidata’ declared inside parameter list [-Werror] Fix this by adding appropriate headers. Note: Both these issues can result in silent config failures because the compile failure is taken to mean "this option is not supported by this kernel" rather than "there's something wrong with the config test". This can lead to something merely annoying (compile failures) to something potentially serious (miscompiled or misused kernel primitives or functions). E.g. the fixes included here resulted in these additional defines in zfs_config.h with linux v4.14.19: Also, drive-by whitespace fixes in config/* files which don't mention "GNU" (those ones look to be imported from elsewhere so leave them alone). Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: Chris Dunlop <[email protected]> Closes #7169
Diffstat (limited to 'config/kernel-create-nameidata.m4')
-rw-r--r--config/kernel-create-nameidata.m41
1 files changed, 1 insertions, 0 deletions
diff --git a/config/kernel-create-nameidata.m4 b/config/kernel-create-nameidata.m4
index a71490a00..d4c155c57 100644
--- a/config/kernel-create-nameidata.m4
+++ b/config/kernel-create-nameidata.m4
@@ -5,6 +5,7 @@ AC_DEFUN([ZFS_AC_KERNEL_CREATE_NAMEIDATA], [
AC_MSG_CHECKING([whether iops->create() passes nameidata])
ZFS_LINUX_TRY_COMPILE([
#include <linux/fs.h>
+ #include <linux/sched.h>
#ifdef HAVE_MKDIR_UMODE_T
int inode_create(struct inode *inode ,struct dentry *dentry,