diff options
| author | Damian Szuberski <[email protected]> | 2021-11-30 19:23:10 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-11-30 10:23:10 -0800 |
| commit | 34eef3e9a7a74d24a59d016051d547afc55dbaa0 (patch) | |
| tree | c75ff6fda4ee9582ed2ebb5b1a71a529242c3d78 /config/Shellcheck.am | |
| parent | 4325de09cd2993837bc32a83d61872b57e58298e (diff) | |
Pass `--enable=all` to shellcheck within contrib/
- Remove `SHELLCHECK_IGNORE` in favor of inline suppressions
and more general `SHELLCHECK_OPTS`.
- Exclude `SC2250` (turned on by `--enable=all`) globally
- Pass `--enable=all` to shellcheck for scripts in contrib/: it's
very important to catch errors early in areas that are not easily
testable.
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes #12760
Diffstat (limited to 'config/Shellcheck.am')
| -rw-r--r-- | config/Shellcheck.am | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/config/Shellcheck.am b/config/Shellcheck.am index 6b805b797..e255e6733 100644 --- a/config/Shellcheck.am +++ b/config/Shellcheck.am @@ -1,7 +1,7 @@ .PHONY: shellcheck shellcheck: $(SCRIPTS) $(SHELLCHECKSCRIPTS) if HAVE_SHELLCHECK - [ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; shellcheck $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") --exclude=SC1090,SC1091$(SHELLCHECK_IGNORE) --format=gcc $(SCRIPTS) $(SHELLCHECKSCRIPTS) + [ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; shellcheck --format=gcc --exclude=SC1090,SC1091,SC2250 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") $(SHELLCHECK_OPTS) $(SCRIPTS) $(SHELLCHECKSCRIPTS) else @[ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; echo "skipping shellcheck of" $(SCRIPTS) $(SHELLCHECKSCRIPTS) "because shellcheck is not installed" endif |