diff options
| author | Etienne Dechamps <[email protected]> | 2012-09-27 13:31:46 +0200 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2012-10-03 13:32:48 -0700 |
| commit | 0aebd4f9e3223e8f1e09de7b29bba4f375db840c (patch) | |
| tree | 87de1c6b6e8ba60d124a5bafe8880aa69cbff254 /cmd/ztest | |
| parent | 6d1d976b2c2c6b80de75a480c998466068066846 (diff) | |
Create threads in detached state in userspace.
Currently, thread_create(), when called in userspace, creates a
joinable (i.e. not detached thread). This is the pthread default.
Unfortunately, this does not reproduce kthreads behavior (kthreads
are always detached). In addition, this contradicts the original
Solaris code which creates userspace threads in detached mode.
These joinable threads are never joined, which leads to a leakage of
pthread thread objects ("zombie threads"). This in turn results in
excessive ressource consumption, and possible ressource exhaustion in
extreme cases (e.g. long ztest runs).
This patch fixes the issue by creating userspace threads in detached
mode. The only exception is ztest worker threads which are meant to be
joinable.
Signed-off-by: Brian Behlendorf <[email protected]>
Issue #989
Diffstat (limited to 'cmd/ztest')
| -rw-r--r-- | cmd/ztest/ztest.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/cmd/ztest/ztest.c b/cmd/ztest/ztest.c index 15f170d43..ff14c6722 100644 --- a/cmd/ztest/ztest.c +++ b/cmd/ztest/ztest.c @@ -5390,8 +5390,9 @@ ztest_run(ztest_shared_t *zs) /* * Create a thread to periodically resume suspended I/O. */ - VERIFY3P((resume_thread = thread_create(NULL, 0, ztest_resume_thread, - spa, TS_RUN, NULL, 0, 0)), !=, NULL); + VERIFY3P((resume_thread = zk_thread_create(NULL, 0, + (thread_func_t)ztest_resume_thread, spa, TS_RUN, NULL, 0, 0, + PTHREAD_CREATE_JOINABLE)), !=, NULL); /* * Set a deadman alarm to abort() if we hang. @@ -5437,8 +5438,10 @@ ztest_run(ztest_shared_t *zs) if (t < zopt_datasets && ztest_dataset_open(zs, t) != 0) return; - VERIFY3P(thread = thread_create(NULL, 0, ztest_thread, - (void *)(uintptr_t)t, TS_RUN, NULL, 0, 0), !=, NULL); + VERIFY3P(thread = zk_thread_create(NULL, 0, + (thread_func_t)ztest_thread, + (void *)(uintptr_t)t, TS_RUN, NULL, 0, 0, + PTHREAD_CREATE_JOINABLE), !=, NULL); tid[t] = thread->t_tid; } |