diff options
| author | loli10K <[email protected]> | 2019-05-28 20:14:58 +0200 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2019-05-28 11:14:58 -0700 |
| commit | 0869b74a1edc1e3375b560f788038615f37feac4 (patch) | |
| tree | af9285b94298a84b942ef22fe109f795c7adea92 /cmd/zpool | |
| parent | 841a7a98fc4623e0bcecfa393e7818ade4198a15 (diff) | |
Endless loop in zpool_do_remove() on platforms with unsigned char
On systems where "char" is an unsigned type the value returned by
getopt() will never be negative (-1), leading to an endless loop:
this issue prevents both 'zpool remove' and 'zstreamdump' for
working on some systems.
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Chris Dunlop <[email protected]>
Signed-off-by: loli10K <[email protected]>
Closes #8789
Diffstat (limited to 'cmd/zpool')
| -rw-r--r-- | cmd/zpool/zpool_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/zpool/zpool_main.c b/cmd/zpool/zpool_main.c index 5d3191476..2cb6774b9 100644 --- a/cmd/zpool/zpool_main.c +++ b/cmd/zpool/zpool_main.c @@ -973,7 +973,7 @@ zpool_do_remove(int argc, char **argv) int i, ret = 0; zpool_handle_t *zhp = NULL; boolean_t stop = B_FALSE; - char c; + int c; boolean_t noop = B_FALSE; boolean_t parsable = B_FALSE; |