diff options
| author | Chris Dunlap <[email protected]> | 2014-04-08 15:31:36 -0700 |
|---|---|---|
| committer | Brian Behlendorf <[email protected]> | 2014-04-09 13:32:54 -0700 |
| commit | 6ac770b1961b9468daf0c69eae6515c608535789 (patch) | |
| tree | 073446e64b68d7fc66ccc0c015fc393be60c51c4 /cmd/zed/zed_file.h | |
| parent | 7368eb621e6c94dd8fd37020568f32c120afabf9 (diff) | |
Replace zed_file_create_dirs() with mkdirp()
When processing directory components starting from the root dir,
zed_file_create_dirs() contained a bug in checking the return value of
mkdir(). A typo was made, and the test for (mkdir_errno != EEXIST) was
erroneously written as (mkdir_errno == EEXIST). If some of the leading
directory components already existed, this bug would cause the routine
to exit before creating the remaining directory components.
Instead of fixing the above mkdir_errno test, this commit replaces
zed_file_create_dirs() with mkdirp(). This cleanup was already
planned, and zed_file_create_dirs() only existed because I didn't
realize mkdirp() was already in tree at the time.
Signed-off-by: Chris Dunlap <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #2248
Diffstat (limited to 'cmd/zed/zed_file.h')
| -rw-r--r-- | cmd/zed/zed_file.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/cmd/zed/zed_file.h b/cmd/zed/zed_file.h index 6a31dc3d6..df7020182 100644 --- a/cmd/zed/zed_file.h +++ b/cmd/zed/zed_file.h @@ -44,6 +44,4 @@ void zed_file_close_from(int fd); int zed_file_close_on_exec(int fd); -int zed_file_create_dirs(const char *dir_name); - #endif /* !ZED_FILE_H */ |